Skip to content

Commit 9f2e804

Browse files
negar7918joschi
authored andcommitted
Renamed frame header to octet counting as specified in RFC 6587. (#7)
* Renamed frame header to octet counting as specified in RFC 6587. * Introduced date argument in log method when structured message is sent as argument.
1 parent fdba539 commit 9f2e804

File tree

6 files changed

+29
-9
lines changed

6 files changed

+29
-9
lines changed

src/main/java/org/graylog2/syslog4j/SyslogIF.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ public interface SyslogIF extends SyslogConstants {
4444
public void emergency(String message);
4545

4646
public void log(int level, SyslogMessageIF message);
47+
48+
public void log(int level, SyslogMessageIF message, Date datetime);
4749

4850
public void debug(SyslogMessageIF message);
4951

src/main/java/org/graylog2/syslog4j/impl/AbstractSyslog.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,20 @@ public void log(int level, SyslogMessageIF message) {
149149
log(getMessageProcessor(), level, message.createMessage());
150150
}
151151
}
152+
153+
public void log(int level, SyslogMessageIF message, Date datetime) {
154+
if (message instanceof StructuredSyslogMessageIF) {
155+
if (getMessageProcessor() instanceof StructuredSyslogMessageProcessor) {
156+
log(getMessageProcessor(), level, message.createMessage(), datetime);
157+
158+
} else {
159+
log(getStructuredMessageProcessor(), level, message.createMessage(), datetime);
160+
}
161+
162+
} else {
163+
log(getMessageProcessor(), level, message.createMessage(), datetime);
164+
}
165+
}
152166

153167
public void debug(String message) {
154168
log(LEVEL_DEBUG, message);

src/main/java/org/graylog2/syslog4j/impl/multiple/MultipleSyslog.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,4 +178,8 @@ public void log(int level, String message, Date datetime) {
178178

179179
}
180180

181+
public void log(int level, SyslogMessageIF message, Date datetime) {
182+
183+
}
184+
181185
}

src/main/java/org/graylog2/syslog4j/impl/net/tcp/TCPNetSyslogConfig.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class TCPNetSyslogConfig extends AbstractNetSyslogConfig implements TCPNe
5454
* 89 <165>1 2003-10-11T22:14:15.003Z mymachine.example.com evntslog - ID47 [exampleSDID@32473]
5555
*
5656
*/
57-
private boolean useFrameHeader;
57+
private boolean useOctetCounting;
5858

5959
public TCPNetSyslogConfig() {
6060
initialize();
@@ -161,12 +161,12 @@ public void setFreshConnectionInterval(int freshConnectionInterval) {
161161
this.freshConnectionInterval = freshConnectionInterval;
162162
}
163163

164-
public void setUseFrameHeader(boolean useFrameHeader) {
165-
this.useFrameHeader = useFrameHeader;
164+
public void setUseOctetCounting(boolean useOctetCounting) {
165+
this.useOctetCounting = useOctetCounting;
166166
}
167167

168-
public boolean isUseFrameHeader() {
169-
return this.useFrameHeader;
168+
public boolean isUseOctetCounting() {
169+
return this.useOctetCounting;
170170
}
171171

172172
public Class getSyslogWriterClass() {

src/main/java/org/graylog2/syslog4j/impl/net/tcp/TCPNetSyslogConfigIF.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public interface TCPNetSyslogConfigIF extends AbstractNetSyslogConfigIF {
4646

4747
public void setFreshConnectionInterval(int interval);
4848

49-
public void setUseFrameHeader(boolean useFrameHeader);
49+
public void setUseOctetCounting(boolean useFrameHeader);
5050

51-
public boolean isUseFrameHeader();
51+
public boolean isUseOctetCounting();
5252
}

src/main/java/org/graylog2/syslog4j/impl/net/tcp/TCPNetSyslogWriter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ public void write(byte[] message) throws SyslogRuntimeException {
141141
OutputStream os = currentSocket.getOutputStream();
142142

143143
String frameHeader = "";
144-
if(this.tcpNetSyslogConfig.isUseFrameHeader()){
144+
if(this.tcpNetSyslogConfig.isUseOctetCounting()){
145145
frameHeader = message.length + " ";
146146
}
147147

@@ -152,7 +152,7 @@ public void write(byte[] message) throws SyslogRuntimeException {
152152
os.write(frameHeader.getBytes());
153153
os.write(message);
154154

155-
if(!this.tcpNetSyslogConfig.isUseFrameHeader()) {
155+
if(!this.tcpNetSyslogConfig.isUseOctetCounting()) {
156156
byte[] delimiterSequence = this.tcpNetSyslogConfig.getDelimiterSequence();
157157
if (delimiterSequence != null && delimiterSequence.length > 0) {
158158
os.write(delimiterSequence);

0 commit comments

Comments
 (0)