100% coverage, tidy make and README.md

Author: Harry Bragg

.gitignore

@@ -1,2 +1,3 @@
 /vendor/
 composer.lock
+/tests/report/

Makefile

@@ -1,4 +1,4 @@
-.PHONY: test test-coverage test-unit test-unit-coverage test-functional test-functional-coverage install
+.PHONY: test lint lint-auto-fix test-coverage test-unit test-unit-coverage test-functional test-functional-coverage test-performance install
 
 test:
 	@./vendor/bin/phpunit --exclude-group performance
@@ -10,7 +10,7 @@ lint-auto-fix:
 	@./vendor/bin/phpcbf -p --standard=PSR2 src/ tests/
 
 test-coverage:
-	@./vendor/bin/phpunit --coverage-text --coverage-html ./tests/report
+	@./vendor/bin/phpunit --coverage-text --coverage-html ./tests/report --exclude-group performance
 
 test-unit:
 	@./vendor/bin/phpunit --testsuite unit

README.md

@@ -8,11 +8,11 @@
 [![Total Downloads](https://img.shields.io/packagist/dt/graze/gigya-client.svg?style=flat-square)](https://packagist.org/packages/graze/gigya-client)
 [![StyleCI](https://styleci.io/repos/43295589/shield)](https://styleci.io/repos/43295589)
 
-Basic Client for Gigya's REST API
+Client for Gigya's REST API
 
 ## Install
 
-Via Composer
+The simplest way to install the client is with composer and running:
 
 ``` bash
 $ composer require graze/gigya-client
@@ -21,8 +21,8 @@ $ composer require graze/gigya-client
 ## Usage
 
 ``` php
-$client = new \Graze\Gigya\Gigya($key, $secret, Gigya::DC_EU);
-$response = $client->accounts()->getAccountInfo(['uid' => $uid]);
+$gigya = new Gigya($key, $secret);
+$response = $gigya->accounts()->getAccountInfo(['uid' => $uid]);
 $account = $response->getData();
 ```
 

tests/unit/GigyaTest.php

@@ -117,13 +117,12 @@ private function setupCall($fixtureName, $uri, $getOptions, $key, $secret, $user
         $response = m::mock('GuzzleHttp\Message\ResponseInterface');
         $response->shouldReceive('getBody')->andReturn(TestFixtures::getFixture($fixtureName));
 
-        $this->guzzleClient
-            ->shouldReceive('get')
-            ->with(
-                $uri,
-                $getOptions
-            )
-            ->andReturn($response);
+        $this->guzzleClient->shouldReceive('get')
+                           ->with(
+                               $uri,
+                               $getOptions
+                           )
+                           ->andReturn($response);
 
         $gigyaResponse = m::mock('Graze\Gigya\Response\ResponseInterface');
 
@@ -134,6 +133,58 @@ private function setupCall($fixtureName, $uri, $getOptions, $key, $secret, $user
         return $gigyaResponse;
     }
 
+    public function testConstructorConfig()
+    {
+
+        $this->guzzleClient->shouldReceive('__construct')
+                           ->once()
+                           ->with([
+                               'emitter' => $this->emitter,
+                           ])
+                           ->andReturn($this->guzzleClient);
+
+        $this->emitter->shouldReceive('attach')
+                      ->with(m::type(ValidGigyaResponseSubscriber::class))
+                      ->once();
+
+        $response = m::mock('GuzzleHttp\Message\ResponseInterface');
+        $response->shouldReceive('getBody')->andReturn(TestFixtures::getFixture('account.getAccountInfo'));
+
+        $this->guzzleClient->shouldReceive('get')
+                           ->with(
+                               'https://accounts.au1.gigya.com/accounts.getAccountInfo',
+                               [
+                                   'cert'   => 'some_cert.pem',
+                                   'auth'   => 'oauth',
+                                   'verify' => $this->certPath,
+                                   'query'  => [],
+                               ]
+                           )
+                           ->andReturn($response);
+
+        $gigyaResponse = m::mock('Graze\Gigya\Response\ResponseInterface');
+
+        $this->factory->shouldReceive('getResponse')
+                      ->with($response)
+                      ->andReturn($gigyaResponse);
+
+        $config = [
+            'dataCenter'   => Gigya::DC_AU,
+            'auth'         => 'oauth',
+            'uidValidator' => false,
+            'factory'      => $this->factory,
+            'guzzle'       => [
+                'emitter' => $this->emitter,
+            ],
+            'options'      => [
+                'cert' => 'some_cert.pem',
+            ],
+        ];
+        $client = new Gigya('key', 'secret', null, $config);
+
+        static::assertSame($gigyaResponse, $client->accounts()->getAccountInfo());
+    }
+
     public function testSettingKeyAndSecretWillPassToGuzzleClient()
     {
         $key    = 'key' . rand(1, 1000);

tests/unit/Validation/ValidGigyaResponseSubscriberTest.php

@@ -2,6 +2,7 @@
 
 namespace Graze\Gigya\Test\Unit\Validation;
 
+use Graze\Gigya\Exception\UnknownResponseException;
 use Graze\Gigya\Test\TestCase;
 use Graze\Gigya\Test\TestFixtures;
 use Graze\Gigya\Validation\ValidGigyaResponseSubscriber;
@@ -115,4 +116,19 @@ public function testInvalidBody()
 
         $this->validator->onComplete($completeEvent, 'name');
     }
+
+    public function testUnknownResponseContainsTheOriginalResponse()
+    {
+        $completeEvent = m::mock(CompleteEvent::class);
+        $response      = m::mock('GuzzleHttp\Message\ResponseInterface');
+        $completeEvent->shouldReceive('getResponse')
+                      ->andReturn($response);
+        $response->shouldReceive('getBody')->andReturn(TestFixtures::getFixture('invalid_json'));
+
+        try {
+            $this->validator->onComplete($completeEvent, 'name');
+        } catch (UnknownResponseException $e) {
+            static::assertSame($response, $e->getResponse());
+        }
+    }
 }