Merge pull request #78 from wschurman/rn-0.47-breaking-change

gre · web-flow · commit 4c0e9ecc1e0f · 2017-08-03T18:25:41.000+02:00
Remove override of 'createJSModules' for RN 0.47
diff --git a/android/src/main/java/fr/greweb/reactnativeviewshot/RNViewShotPackage.java b/android/src/main/java/fr/greweb/reactnativeviewshot/RNViewShotPackage.java
@@ -16,7 +16,8 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte
       return Arrays.<NativeModule>asList(new RNViewShotModule(reactContext));
     }
 
-    @Override
+    // Deprecated RN 0.47
+    // @Override
     public List<Class<? extends JavaScriptModule>> createJSModules() {
       return Collections.emptyList();
     }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,8 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactConte`
`16`	`16`	`return Arrays.<NativeModule>asList(new RNViewShotModule(reactContext));`
`17`	`17`	`}`
`18`	`18`
`19`		`- @Override`
	`19`	`+ // Deprecated RN 0.47`
	`20`	`+ // @Override`
`20`	`21`	`public List<Class<? extends JavaScriptModule>> createJSModules() {`
`21`	`22`	`return Collections.emptyList();`
`22`	`23`	`}`