Skip to content

Commit 7d1d61b

Browse files
committed
update README
1 parent 84fd7ca commit 7d1d61b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ Model tested: iPhone 6 (iOS), Nexus 5 (Android).
6969
| System | iOS | Android |
7070
|--------------------|--------------------|-------------------|
7171
| View,Text,Image,.. | YES | YES |
72-
| WebView | YES | YES: with a `<View collapsable={false}>` parent |
73-
| gl-react | YES | NO (empty) |
72+
| WebView | YES | YES, but from a `<View collapsable={false}>` parent |
73+
| gl-react v2 | YES | NO (empty) |
7474
| react-native-video | NO | NO |
7575
| react-native-maps | YES | [NO](https://github.com/gre/react-native-view-shot/issues/36) |
7676

@@ -84,7 +84,7 @@ Snapshots are not guaranteed to be pixel perfect. It also depends on the platfor
8484

8585
### specific to Android implementation
8686

87-
- you need to make sure `collapsable` is set to `false` if you want to snapshot a **View**. Otherwise that view won't reflect any UI View. ([found by @gaguirre](https://github.com/gre/react-native-view-shot/issues/7#issuecomment-245302844))
87+
- you need to make sure `collapsable` is set to `false` if you want to snapshot a **View**. Some content might even need to be wrapped into such `<View collapsable={false}>` to actually make them snapshotable! Otherwise that view won't reflect any UI View. ([found by @gaguirre](https://github.com/gre/react-native-view-shot/issues/7#issuecomment-245302844))
8888
- if you implement a third party library and want to get back a File, you must first resolve the `Uri`. (the `file` result returns an `Uri` so it's consistent with iOS and can be given to APIs like `Image.getSize`)
8989

9090
## Getting started

0 commit comments

Comments
 (0)