Skip to content

Commit 3e0aae2

Browse files
E000391dedece35
authored andcommitted
add rule to javaCheckRegistrar
1 parent 4f97eed commit 3e0aae2

File tree

2 files changed

+28
-34
lines changed

2 files changed

+28
-34
lines changed

src/main/java/org/greencodeinitiative/creedengo/java/JavaCheckRegistrar.java

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
2-
* creedengo - Java language - Provides rules to reduce the environmental footprint of your Java programs
3-
* Copyright © 2024 Green Code Initiative (https://green-code-initiative.org/)
2+
* ecoCode - Java language - Provides rules to reduce the environmental footprint of your Java programs
3+
* Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU General Public License as published by
@@ -15,26 +15,26 @@
1515
* You should have received a copy of the GNU General Public License
1616
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1717
*/
18-
package org.greencodeinitiative.creedengo.java;
18+
package fr.greencodeinitiative.java;
1919

2020
import java.util.Collections;
2121
import java.util.List;
2222

23-
import org.greencodeinitiative.creedengo.java.checks.ArrayCopyCheck;
24-
import org.greencodeinitiative.creedengo.java.checks.AvoidFullSQLRequest;
25-
import org.greencodeinitiative.creedengo.java.checks.AvoidGettingSizeCollectionInLoop;
26-
import org.greencodeinitiative.creedengo.java.checks.AvoidMultipleIfElseStatement;
27-
import org.greencodeinitiative.creedengo.java.checks.AvoidRegexPatternNotStatic;
28-
import org.greencodeinitiative.creedengo.java.checks.AvoidSQLRequestInLoop;
29-
import org.greencodeinitiative.creedengo.java.checks.AvoidSetConstantInBatchUpdate;
30-
import org.greencodeinitiative.creedengo.java.checks.AvoidSpringRepositoryCallInLoopOrStreamCheck;
31-
import org.greencodeinitiative.creedengo.java.checks.AvoidStatementForDMLQueries;
32-
import org.greencodeinitiative.creedengo.java.checks.AvoidUsageOfStaticCollections;
33-
import org.greencodeinitiative.creedengo.java.checks.FreeResourcesOfAutoCloseableInterface;
34-
import org.greencodeinitiative.creedengo.java.checks.IncrementCheck;
35-
import org.greencodeinitiative.creedengo.java.checks.InitializeBufferWithAppropriateSize;
36-
import org.greencodeinitiative.creedengo.java.checks.NoFunctionCallWhenDeclaringForLoop;
37-
import org.greencodeinitiative.creedengo.java.checks.OptimizeReadFileExceptions;
23+
(??)import org.greencodeinitiative.creedengo.java.checks.ArrayCopyCheck;
24+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidFullSQLRequest;
25+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidGettingSizeCollectionInLoop;
26+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidMultipleIfElseStatement;
27+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidRegexPatternNotStatic;
28+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidSQLRequestInLoop;
29+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidSetConstantInBatchUpdate;
30+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidSpringRepositoryCallInLoopOrStreamCheck;
31+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidStatementForDMLQueries;
32+
(??)import org.greencodeinitiative.creedengo.java.checks.AvoidUsageOfStaticCollections;
33+
(??)import org.greencodeinitiative.creedengo.java.checks.FreeResourcesOfAutoCloseableInterface;
34+
(??)import org.greencodeinitiative.creedengo.java.checks.IncrementCheck;
35+
(??)import org.greencodeinitiative.creedengo.java.checks.InitializeBufferWithAppropriateSize;
36+
(??)import org.greencodeinitiative.creedengo.java.checks.NoFunctionCallWhenDeclaringForLoop;
37+
(??)import org.greencodeinitiative.creedengo.java.checks.OptimizeReadFileExceptions;
3838
import org.sonar.plugins.java.api.CheckRegistrar;
3939
import org.sonar.plugins.java.api.JavaCheck;
4040
import org.sonarsource.api.sonarlint.SonarLintSide;
@@ -47,7 +47,7 @@
4747
*/
4848
@SonarLintSide
4949
public class JavaCheckRegistrar implements CheckRegistrar {
50-
static final List<Class<? extends JavaCheck>> ANNOTATED_RULE_CLASSES = List.of(
50+
private static final List<Class<? extends JavaCheck>> ANNOTATED_RULE_CLASSES = List.of(
5151
ArrayCopyCheck.class,
5252
IncrementCheck.class,
5353
AvoidUsageOfStaticCollections.class,
@@ -62,7 +62,8 @@ public class JavaCheckRegistrar implements CheckRegistrar {
6262
InitializeBufferWithAppropriateSize.class,
6363
AvoidSetConstantInBatchUpdate.class,
6464
FreeResourcesOfAutoCloseableInterface.class,
65-
AvoidMultipleIfElseStatement.class
65+
AvoidMultipleIfElseStatement.class,
66+
UseOptionalOrElseGetVsOrElse.class
6667
);
6768

6869
/**
Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/*
2-
* creedengo - Java language - Provides rules to reduce the environmental footprint of your Java programs
3-
* Copyright © 2024 Green Code Initiative (https://green-code-initiative.org/)
2+
* ecoCode - Java language - Provides rules to reduce the environmental footprint of your Java programs
3+
* Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
44
*
55
* This program is free software: you can redistribute it and/or modify
66
* it under the terms of the GNU General Public License as published by
@@ -15,13 +15,9 @@
1515
* You should have received a copy of the GNU General Public License
1616
* along with this program. If not, see <http://www.gnu.org/licenses/>.
1717
*/
18-
package org.greencodeinitiative.creedengo.java;
19-
20-
import java.util.Set;
18+
package fr.greencodeinitiative.java;
2119

2220
import org.junit.jupiter.api.Test;
23-
import org.reflections.Reflections;
24-
import org.sonar.check.Rule;
2521
import org.sonar.plugins.java.api.CheckRegistrar;
2622

2723
import static org.assertj.core.api.Assertions.assertThat;
@@ -34,14 +30,11 @@ void checkNumberRules() {
3430

3531
final JavaCheckRegistrar registrar = new JavaCheckRegistrar();
3632
registrar.register(context);
37-
assertThat(context.checkClasses())
38-
.describedAs("All implemented rules must be registered into " + JavaCheckRegistrar.class)
39-
.containsExactlyInAnyOrder(getDefinedRules().toArray(new Class[0]));
33+
(??) assertThat(context.checkClasses())
34+
(??) .describedAs("All implemented rules must be registered into " + JavaCheckRegistrar.class)
35+
(??) .containsExactlyInAnyOrder(getDefinedRules().toArray(new Class[0]));
4036
assertThat(context.testCheckClasses()).isEmpty();
41-
}
4237

43-
static Set<Class<?>> getDefinedRules() {
44-
Reflections r = new Reflections(JavaCheckRegistrar.class.getPackageName() + ".checks");
45-
return r.getTypesAnnotatedWith(Rule.class);
4638
}
39+
4740
}

0 commit comments

Comments
 (0)