Skip to content

Commit 8e56685

Browse files
PREISNER Julienjpreisner
authored andcommitted
refactor: don't unnecessarily call methods when writing with LOGGER.debug()
1 parent 0449ce6 commit 8e56685

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/main/java/org/greencodeinitiative/creedengo/java/checks/MakeNonReassignedVariablesConstants.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,13 @@ public List<Kind> nodesToVisit() {
2525
@Override
2626
public void visitNode(@Nonnull Tree tree) {
2727
VariableTree variableTree = (VariableTree) tree;
28-
LOGGER.debug("Variable > " + getVariableNameForLogger(variableTree));
29-
LOGGER.debug(" => isNotFinalAndNotStatic(variableTree) = " + isNotFinalAndNotStatic(variableTree));
30-
LOGGER.debug(" => usages = " + variableTree.symbol().usages().size());
31-
LOGGER.debug(" => isNotReassigned = " + isNotReassigned(variableTree));
32-
LOGGER.debug(" => isPassedAsNonFinalParameter = " + isPassedAsNonFinalParameter(variableTree));
33-
28+
if (LOGGER.isDebugEnabled()) {
29+
LOGGER.debug("Variable > {}", getVariableNameForLogger(variableTree));
30+
LOGGER.debug(" => isNotFinalAndNotStatic(variableTree) = {}", isNotFinalAndNotStatic(variableTree));
31+
LOGGER.debug(" => usages = {}", variableTree.symbol().usages().size());
32+
LOGGER.debug(" => isNotReassigned = {}", isNotReassigned(variableTree));
33+
LOGGER.debug(" => isPassedAsNonFinalParameter = {}", isPassedAsNonFinalParameter(variableTree));
34+
}
3435
if (isNotFinalAndNotStatic(variableTree) && isNotReassigned(variableTree)) {
3536
reportIssue(tree, MESSAGE_RULE);
3637
} else {

0 commit comments

Comments
 (0)