Skip to content

Conversation

@pataluc
Copy link
Contributor

@pataluc pataluc commented May 21, 2025

Tests files has been kept only in src/it/test-projects, Unit tests now read it from there... Also, suggestion to reorder each test file in a subfolder named after the rule number, like suggested for GCI67

Fixes #56

@pataluc pataluc force-pushed the chore/56-testsfile-in-one-place branch 2 times, most recently from 7fe923d to 03c6c06 Compare May 26, 2025 06:24
Tests files has been kept only in src/it/test-projects, Unit tests now read it from there...
Also, suggestion to reorder each test file in a subfolder named after the rule number, like suggested for GCI67

Fixes green-code-initiative#56
@pataluc pataluc force-pushed the chore/56-testsfile-in-one-place branch from 03c6c06 to 36f5965 Compare May 26, 2025 06:41
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for the huge contribution on this 💥
Maybe we can wait a little bit to integrate other works done during the challenge before this? This will avoid conflict in all other PRs

@pataluc
Copy link
Contributor Author

pataluc commented Jun 6, 2025

Hello! Thank you for the huge contribution on this 💥 Maybe we can wait a little bit to integrate other works done during the challenge before this? This will avoid conflict in all other PRs

Agreed, seems the right thing to do. This PR offers a way to do it, it should be pretty easy to rebase other changes after they're merged.

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve structure and content of the examples Java sources

2 participants