Skip to content

Conversation

@dedece35
Copy link
Member

No description provided.

@dedece35 dedece35 requested a review from Copilot August 30, 2025 16:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements JDK 11 retro-compatibility by downgrading Java version requirements and associated dependencies throughout the project. The changes enable the creedengo Java plugin to work with older Java environments while maintaining functionality.

  • Downgrade Java version from 17 to 11 across all Maven configurations
  • Update Spring dependencies to versions compatible with JDK 11
  • Adjust SonarQube and plugin versions to support the older Java runtime

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/it/test-projects/creedengo-java-plugin-test-project/pom.xml Updates test project to use Java 11 and downgrades Spring dependencies
pom.xml Changes main project Java version, SonarQube versions, and Maven plugin versions for JDK 11 compatibility
Dockerfile Switches Docker base image from OpenJDK 17 to OpenJDK 11 and updates SonarQube version

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

utarwyn
utarwyn previously approved these changes Sep 8, 2025
@dedece35 dedece35 marked this pull request as draft September 12, 2025 08:01
@dedece35 dedece35 self-assigned this Sep 12, 2025
@dedece35 dedece35 added the 🚀 enhancement New feature or request label Sep 12, 2025
@dedece35
Copy link
Member Author

Converted to Draft until decision by core-team if we keep JDK11 compatibility for all our plugins

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚀 enhancement New feature or request stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants