Skip to content

[CHALLENGE24][GCI95][S.T.E.P] : Use every column queried #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

[CHALLENGE24][GCI95][S.T.E.P] : Use every column queried #63

wants to merge 33 commits into from

Conversation

@max-208
Copy link
Contributor

@max-208 max-208 commented Aug 19, 2024

created in mostly during the ecocode challenge 2024, this rule aims to avoid doing sql queries and not using selected columns. rule specification here

Denielig and others added 19 commits May 30, 2024 09:46
@pataluc
feat: add test files
6032969
@max-208
feat: 🚧 EC1024 skeleton
9419960
feat: add test class
f790569
Fix: fix class and file name
2facdf2
@max-208
feat: 🚧 WIP : create rule EC10044
a916018
@max-208
Merge branch '1044-java' of github.com:max-208/ecoCode-java into 1044…
3ad7732 
…-java
fix: improve test
5a8eb15
@max-208
feat: 🚧 WIP finish rule creation for EC1044 rule
de78977
@max-208
Merge branch '1044-java' of github.com:max-208/ecoCode-java into 1044…
756e40e 
…-java
@max-208
feat: 🚧 WIP : create rule 1044
c6eaa43
@max-208
feat: ✨ created rule 1044
75196b8
@max-208
fix: 🐛 improve false positives detection
e82572d
@max-208
refactor: ♻️ quick refactor
759b8ad
@max-208
refactor: ♻️ fix formating
2b7f600
@max-208
remove executeUpdate
30b131f
@max-208
add some comments
647df32
@max-208
small refactor and add comments
50259b0
@max-208
Merge branch 'main' into 1044-java
3cfaf87
@dedece35
Merge branch 'main' into 1044-java
1fc5855
dedece35
dedece35 requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

thank you for your PR !!!
some feedbacks :

  • could you rename each test java file (inside "src/test/files") with a functional name ? like that a developer knows the content and the purpose of each class. If you can add javadoc for more explanations before de the class name, please ?
  • What is the behaviour with a use case like "SELECT * FROM toto" ? can you add this use case test, please ?

dedece35
dedece35 requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a PR inside "ecoCode-java-test-project" repository with your test classes ... can you do it please ?

please check documentation https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#implement-a-new-rule and specifically the "DoD" part to check all mandatories developments are done, please.

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug 🏆 challenge 🏆 Work done during the Green Code Challenge labels Sep 6, 2024
@max-208
Copy link
Contributor Author

max-208 commented Sep 9, 2024

here is the pr in ecocode-java-test-project

@max-208 max-208 requested a review from dedece35 September 11, 2024 07:32
@github-actions github-actions bot removed the stale label Dec 14, 2024
@github-actions
Copy link

github-actions bot commented Jan 14, 2025

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jan 14, 2025
@dedece35
Copy link
Member

dedece35 commented Feb 15, 2025

Hi @max-208,
sorry for my very late answer, could you correct the remaining conflicts to check again this PR.

Thank you, a lot.
David

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 18, 2025
MP-Aubay
MP-Aubay reviewed May 20, 2025
View reviewed changes
Copy link

@MP-Aubay MP-Aubay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you update CHANGELOG.md
  • Two test case are not flag using test-projects and real Sonar (MultipleQueries & UseMethod)

@max-208
Copy link
Contributor Author

max-208 commented May 20, 2025

@MP-Aubay done

@github-actions github-actions bot removed the stale label May 21, 2025
@max-208 max-208 requested a review from MP-Aubay May 21, 2025 06:48
@rducasse
Copy link

rducasse commented May 21, 2025

  • Can you update CHANGELOG.md
  • Two test case are not flag using test-projects and real Sonar (MultipleQueries & UseMethod)

The 2 tests cases are still not flagged in test-projects

OK for the other changes

@max-208 max-208 changed the title [CHALLENGE24][EC1044] : Use every column queried [CHALLENGE24][GCI95] : Use every column queried May 21, 2025
@max-208 max-208 changed the title [CHALLENGE24][GCI95] : Use every column queried [CHALLENGE24][GCI95][S.T.E.P] : Use every column queried May 21, 2025
@github-actions
Copy link

github-actions bot commented Jun 26, 2025

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dedece35 dedece35 Awaiting requested review from dedece35

@MP-Aubay MP-Aubay Awaiting requested review from MP-Aubay

Requested changes must be addressed to merge this pull request.

Assignees

@dedece35 dedece35

@max-208 max-208

Labels

🗃️ rule rule improvment or rule development or bug 🏆 challenge 🏆 Work done during the Green Code Challenge 🔥 in progress 🔥 🚀 enhancement New feature or request stale 👀 👀 waiting commiter 👀 👀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@max-208 @dedece35 @rducasse @MP-Aubay @pataluc