[69] NullPointer exception in eco code java Sonar plugin #70
Conversation
rrousset-michelin
force-pushed
the
green-code-initiative/ISSUE_69
branch
from
d29ec24 to
e43b26d
Compare
| @@ -0,0 +1,45 @@ | |||
| package files; | |||
There was a problem hiding this comment.
please rename this test class with an explicit name corresponding to use case instead of "2"
There was a problem hiding this comment.
I will done it if you want after the merge of this PR (if you don't have time to do it)
| * The "try" should have been poped from the stack before entering here | ||
| */ | ||
| private void calledMethodWithoutTry() throws IOException { | ||
| FileWriter myWriter = new FileWriter("somefilepath"); |
There was a problem hiding this comment.
sorry, but for me, this use case is an "non compliant" case.
This is a good example explaining that if the FileWriter is instanciated inside a private method, it must be protected with a try-with-resource. In this case, it must be done.
Sorry I can't accept the correction ... for me, the global algorithm must be refactored to manage this use case !
|
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
This PR has been automatically marked as stale because it has no activity for 30 days. |
2 participants
No description provided.