GCI535: add support for the numerable library

Author: Fabien Bézagu

eslint-plugin/lib/rules/no-imported-number-format-library.js

@@ -64,6 +64,15 @@ module.exports = {
           context.report(errorReport(node.parent.property));
         }
       },
+      ImportDeclaration(node) {
+        const importedLibraryName = node.source.value;
+        if (importedLibraryName === 'numerable') {
+          const formatSpecifier = node.specifiers.find(specifier => specifier.type === 'ImportSpecifier' && specifier.imported.name === 'format');
+          if (formatSpecifier) {
+            context.report(errorReport(formatSpecifier));
+          }
+        }
+      }
     };
   },
 };

eslint-plugin/tests/lib/rules/no-imported-number-format-library.js

@@ -35,11 +35,14 @@ const ruleTester = new RuleTester({
     sourceType: "module",
   },
 });
-const expectedError = {
+const expectedIdentifierError = {
   messageId: "ShouldNotUseImportedNumberFormatLibrary",
   type: "Identifier",
 };
-
+const expectedImportError = {
+  messageId: "ShouldNotUseImportedNumberFormatLibrary",
+  type: "ImportSpecifier",
+};
 ruleTester.run("no-imported-number-format-library", rule, {
   valid: [
     "new Intl.NumberFormat().format(1000);",
@@ -49,26 +52,37 @@ ruleTester.run("no-imported-number-format-library", rule, {
     const number2 = numbro(2000);
     number2.add(1000);
     `,
+    "import { parse } from 'numerable';",
+    "import { format } from 'date-fns';",
+    "import mysql from 'mysql2';"
   ],
   invalid: [
     {
       code: "numbro(1000).format({thousandSeparated: true});",
-      errors: [expectedError],
+      errors: [expectedIdentifierError],
     },
     {
       code: `
       const number = numbro(1000);
       number.format({thousandSeparated: true});
       `,
-      errors: [expectedError],
+      errors: [expectedIdentifierError],
     },
     {
       code: `
       const number = numbro(1000);
       const number2 = numbro(2000);
       number.format({thousandSeparated: true});
       `,
-      errors: [expectedError],
+      errors: [expectedIdentifierError],
+    },
+    {
+      code: "import { format } from 'numerable';",
+      errors: [expectedImportError],
+    },
+    {
+      code: "import { format as myFormat} from 'numerable';",
+      errors: [expectedImportError],
     },
   ],
 });

test-project/src/no-imported-number-format-library.js

@@ -1,4 +1,5 @@
 import numbro from "numbro";
+import { parse, format } from "numerable"; // Non-compliant: usage of external library to format number
 
 numbro(1000).format({thousandSeparated: true}); // Non-compliant: usage of external library to format number
 
@@ -8,3 +9,6 @@ variable.format({thousandSeparated: true}); // Non-compliant: usage of external
 numbro(2000).add(1000); // Compliant
 
 new Intl.NumberFormat().format(1000); // Compliant
+
+format(28);
+parse("29"); // Compliant