Skip to content

Commit fc57e66

Browse files
author
Mathis Girault
committed
fix lint and readme
1 parent dd2ce4a commit fc57e66

File tree

2 files changed

+22
-26
lines changed

2 files changed

+22
-26
lines changed

eslint-plugin/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ If your project uses a legacy ESLint version, it may use as well the now depreca
114114
| [avoid-autoplay](docs/rules/avoid-autoplay.md) | Avoid autoplay for videos and audio content ||
115115
| [avoid-brightness-override](docs/rules/avoid-brightness-override.md) | Should avoid to override brightness ||
116116
| [avoid-css-animations](docs/rules/avoid-css-animations.md) | Avoid usage of CSS animations ||
117+
| [avoid-getters-and-setters](docs/rules/avoid-getters-and-setters.md) | Avoid rewriting native getter and setters. ||
117118
| [avoid-high-accuracy-geolocation](docs/rules/avoid-high-accuracy-geolocation.md) | Avoid using high accuracy geolocation in web applications ||
118119
| [avoid-keep-awake](docs/rules/avoid-keep-awake.md) | Avoid screen keep awake ||
119120
| [limit-db-query-results](docs/rules/limit-db-query-results.md) | Should limit the number of returns for a SQL query ||

eslint-plugin/lib/rules/avoid-getters-and-setters.js

Lines changed: 21 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ module.exports = {
2828
recommended: "warn",
2929
},
3030
messages: {
31-
avoidGettersAndSetters: "Avoid rewriting native getter and setters for direct property access.",
31+
avoidGettersAndSetters:
32+
"Avoid rewriting native getter and setters for direct property access.",
3233
},
3334
schema: [],
3435
},
@@ -37,21 +38,16 @@ module.exports = {
3738
* Checks if a getter simply returns an object property.
3839
*/
3940
function isSimpleGetter(node) {
40-
if (
41-
node.value &&
42-
node.value.body &&
43-
node.value.body.body.length === 1
44-
) {
41+
if (node.value && node.value.body && node.value.body.body.length === 1) {
4542
const stmt = node.value.body.body[0];
4643
if (
4744
stmt.type === "ReturnStatement" &&
4845
stmt.argument &&
49-
(
50-
// return this.foo;
51-
(stmt.argument.type === "MemberExpression" && stmt.argument.object.type === "ThisExpression") ||
46+
// return this.foo;
47+
((stmt.argument.type === "MemberExpression" &&
48+
stmt.argument.object.type === "ThisExpression") ||
5249
// return _foo;
53-
(stmt.argument.type === "Identifier")
54-
)
50+
stmt.argument.type === "Identifier")
5551
) {
5652
return true;
5753
}
@@ -63,21 +59,16 @@ module.exports = {
6359
* Checks if a setter simply assigns its parameter to a property (this.foo = value or foo = value).
6460
*/
6561
function isSimpleSetter(node) {
66-
if (
67-
node.value &&
68-
node.value.body &&
69-
node.value.body.body.length === 1
70-
) {
62+
if (node.value && node.value.body && node.value.body.body.length === 1) {
7163
const stmt = node.value.body.body[0];
7264
if (
7365
stmt.type === "ExpressionStatement" &&
7466
stmt.expression.type === "AssignmentExpression" &&
75-
(
76-
// this.foo = value;
77-
(stmt.expression.left.type === "MemberExpression" && stmt.expression.left.object.type === "ThisExpression") ||
67+
// this.foo = value;
68+
((stmt.expression.left.type === "MemberExpression" &&
69+
stmt.expression.left.object.type === "ThisExpression") ||
7870
// foo = value;
79-
(stmt.expression.left.type === "Identifier")
80-
) &&
71+
stmt.expression.left.type === "Identifier") &&
8172
stmt.expression.right.type === "Identifier" &&
8273
node.value.params.length === 1 &&
8374
stmt.expression.right.name === node.value.params[0].name
@@ -91,18 +82,22 @@ module.exports = {
9182
return {
9283
// For object literals: { get foo() {...} } or { set foo(v) {...} }
9384
Property(node) {
94-
if ((node.kind === "get" && isSimpleGetter(node)) ||
95-
(node.kind === "set" && isSimpleSetter(node))) {
85+
if (
86+
(node.kind === "get" && isSimpleGetter(node)) ||
87+
(node.kind === "set" && isSimpleSetter(node))
88+
) {
9689
context.report({ node, messageId: "avoidGettersAndSetters" });
9790
}
9891
},
9992
// For classes: class { get foo() {...} } or class { set foo(v) {...} }
10093
MethodDefinition(node) {
101-
if ((node.kind === "get" && isSimpleGetter(node)) ||
102-
(node.kind === "set" && isSimpleSetter(node))) {
94+
if (
95+
(node.kind === "get" && isSimpleGetter(node)) ||
96+
(node.kind === "set" && isSimpleSetter(node))
97+
) {
10398
context.report({ node, messageId: "avoidGettersAndSetters" });
10499
}
105-
}
100+
},
106101
};
107102
},
108103
};

0 commit comments

Comments
 (0)