[GCI12] EC12 : Disallow multiple style changes at once - Using JS variable

[MP-Aubay]

Hello,

I was wondering how to handle JS variable with the rule GCI12.

For example :

var offsetWidth = 5;
var offsetLeft = 3;
test.value.style.width = `${offsetWidth}px`;
test.value.style.left = `${offsetLeft}px`;

In this example variables are constant but sometimes it is compute in JS, in this case how to replace it with a style block ? Is it a false positive ?

Regards.

[utarwyn]

Hello! Good question, I think it depends.
In your use case, it should be flagged because even if there are variables, the values are constants. But it's not that easy to detect, so I prefer to only support literals and avoid false positives for now. Thank you for the feedback 👍

[MP-Aubay]

Thanks !