Ec36 avoid autoplay #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihebtalan
force-pushed
the
ec36-avoid-autoplay
branch
from
9e1fab7 to
4f1705e
Compare
Co-authored-by: Diane Cordier <[email protected]>
chihebtalan
force-pushed
the
ec36-avoid-autoplay
branch
from
4f1705e to
5a3b699
Compare
Co-authored-by: Diane Cordier <[email protected]>
Co-authored-by: Diane Cordier <[email protected]>
utarwyn
requested changes
May 31, 2024
Member
utarwyn
left a comment
utarwyn
left a comment
There was a problem hiding this comment.
Thank you for this awesome work! 💪 I have done some reviews..
sonar-plugin/src/main/java/io/ecocode/javascript/CheckList.java
Outdated
Show resolved
Hide resolved
sonar-plugin/src/main/resources/io/ecocode/profiles/ecocode_typescript_profile.json
Outdated
Show resolved
Hide resolved
sonar-plugin/src/main/resources/io/ecocode/rules/javascript/EC36.html
Outdated
Show resolved
Hide resolved
sonar-plugin/src/main/resources/io/ecocode/rules/javascript/EC36.json
Outdated
Show resolved
Hide resolved
utarwyn
force-pushed
the
ec36-avoid-autoplay
branch
from
36e50f1 to
593f1f1
Compare
utarwyn
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.