Skip to content

rename EC to GCI #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

rename EC to GCI #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d890d95
rename EC to GCI
Lmgrto Dec 10, 2024
f8a2a93
add @deprecatedRules for old rules
Lmgrto Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [#39](https://github.com/green-code-initiative/ecoCode-javascript/issues/39) Add rule `@ecocode/avoid-brightness-override` (EC522)
- [#41](https://github.com/green-code-initiative/ecoCode-javascript/pull/41) Add rule `@ecocode/no-torch` (EC530)
- Add support for SonarQube up to 10.7
- Rename rules from EC to GCI

### Changed

Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/AvoidBrightnessOverride.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = AvoidBrightnessOverride.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC522")
public class AvoidBrightnessOverride implements EslintBasedCheck {

public static final String RULE_KEY = "EC522";
public static final String RULE_KEY = "GCI522";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/AvoidCSSAnimations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = AvoidCSSAnimations.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC29")
public class AvoidCSSAnimations implements EslintBasedCheck {

public static final String RULE_KEY = "EC29";
public static final String RULE_KEY = "GCI29";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/AvoidHighAccuracyGeolocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,10 @@
@TypeScriptRule
@Rule(key = AvoidHighAccuracyGeolocation.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC8")
@DeprecatedRuleKey(ruleKey = "EC523")
public class AvoidHighAccuracyGeolocation implements EslintBasedCheck {

public static final String RULE_KEY = "EC523";
public static final String RULE_KEY = "GCI523";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/LimitDbQueryResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = LimitDbQueryResult.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC24")
public class LimitDbQueryResult implements EslintBasedCheck {

public static final String RULE_KEY = "EC24";
public static final String RULE_KEY = "GCI24";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/NoEmptyImageSrcAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = NoEmptyImageSrcAttribute.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC25")
public class NoEmptyImageSrcAttribute implements EslintBasedCheck {

public static final String RULE_KEY = "EC25";
public static final String RULE_KEY = "GCI25";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/NoImportAllFromLibrary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = NoImportAllFromLibrary.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC9")
public class NoImportAllFromLibrary implements EslintBasedCheck {

public static final String RULE_KEY = "EC9";
public static final String RULE_KEY = "GCI9";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/NoMultipleAccessDomElement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = NoMultipleAccessDomElement.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC11")
public class NoMultipleAccessDomElement implements EslintBasedCheck {

public static final String RULE_KEY = "EC11";
public static final String RULE_KEY = "GCI11";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/NoMultipleStyleChanges.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = NoMultipleStyleChanges.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC12")
public class NoMultipleStyleChanges implements EslintBasedCheck {

public static final String RULE_KEY = "EC12";
public static final String RULE_KEY = "GCI12";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/NoTorch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = NoTorch.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC530")
public class NoTorch implements EslintBasedCheck {

public static final String RULE_KEY = "EC530";
public static final String RULE_KEY = "GCI530";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/PreferCollectionsWithPagination.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@

@TypeScriptRule
@Rule(key = PreferCollectionsWithPagination.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC13")
public class PreferCollectionsWithPagination implements EslintBasedCheck {

public static final String RULE_KEY = "EC13";
public static final String RULE_KEY = "GCI13";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/PreferShorthandCSSNotations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = PreferShorthandCSSNotations.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC26")
public class PreferShorthandCSSNotations implements EslintBasedCheck {

public static final String RULE_KEY = "EC26";
public static final String RULE_KEY = "GCI26";

@Override
public String eslintKey() {
Expand Down
3 changes: 2 additions & 1 deletion sonar-plugin/src/main/java/io/ecocode/javascript/checks/ProvidePrintCSS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@
@JavaScriptRule
@TypeScriptRule
@Rule(key = ProvidePrintCSS.RULE_KEY)
@DeprecatedRuleKey(ruleKey = "EC30")
public class ProvidePrintCSS implements EslintBasedCheck {

public static final String RULE_KEY = "EC30";
public static final String RULE_KEY = "GCI30";

@Override
public String eslintKey() {
Expand Down
20 changes: 10 additions & 10 deletions sonar-plugin/src/main/resources/io/ecocode/profiles/ecocode_javascript_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"name": "ecoCode",
Copy link
Member

@dedece35 dedece35 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this value and change filename (warning : check where this filename is used to get impacts)

Copy link
Author

@Lmgrto Lmgrto Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes is being processed in another PR
#56

Copy link
Member

@utarwyn utarwyn Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry I will finish this PR asap!

"ruleKeys": [
"EC9",
"EC11",
"EC12",
"EC24",
"EC25",
"EC26",
"EC29",
"EC30",
"EC523",
"EC530"
"GCI9",
"GCI11",
"GCI12",
"GCI24",
"GCI25",
"GCI26",
"GCI29",
"GCI30",
"GCI523",
"GCI530"
]
}
2 changes: 1 addition & 1 deletion sonar-plugin/src/main/resources/io/ecocode/profiles/ecocode_typescript_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ecoCode",
Copy link
Member

@dedece35 dedece35 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same feedback as above

Copy link
Author

@Lmgrto Lmgrto Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, migration for files path is made is another PR
#56

"ruleKeys": [
"EC13"
"GCI13"
]
}
Loading