Skip to content

Avoid triggering an exception (GCI12) #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Avoid triggering an exception (GCI12) #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- [#69](https://github.com/green-code-initiative/creedengo-javascript/pull/69) Only support string literals (GCI11)
- [#70](https://github.com/green-code-initiative/creedengo-javascript/pull/70) Only support SQL queries within standard methods (GCI24)
- [#71](https://github.com/green-code-initiative/creedengo-javascript/pull/71) Avoid triggering an exception (GCI12)

## [2.0.0] - 2025-01-22

Expand Down
16 changes: 9 additions & 7 deletions eslint-plugin/lib/rules/no-multiple-style-changes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ module.exports = {
schema: [],
},
create: function (context) {
function isNodeUseStyleProperty(node) {
return node?.object?.property?.name === "style";
}
const isNodeUseStyleProperty = (node) =>
node?.object?.property?.name === "style";

return {
AssignmentExpression(node) {
Expand All @@ -45,8 +44,10 @@ module.exports = {
const domElementName = node.left.object.object.name;
const currentRangestart = node.left.object.object.range[0];

/** We get the parent AST to check if there is more than one assignation on
the style of the same domElement */
/**
* Store parent AST to check if there is more
* than one assignation on the style of the same domElement
*/
const currentScopeASTBody =
context.getScope().block.body.length != null
? context.getScope().block.body
Expand All @@ -62,10 +63,11 @@ module.exports = {

// De-duplication, prevents multiple alerts for each line involved
const isCurrentNodeTheFirstAssignation =
filtered.length > 1 &&
currentRangestart <=
filtered[0].expression.left.object.object.range[0];
filtered[0].expression.left.object.object.range[0];

if (filtered.length > 1 && isCurrentNodeTheFirstAssignation) {
if (isCurrentNodeTheFirstAssignation) {
context.report({
node,
messageId: "UseClassInstead",
Expand Down
25 changes: 16 additions & 9 deletions eslint-plugin/tests/lib/rules/no-multiple-style-changes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,27 +41,34 @@ ruleTester.run("no-multiple-style-changes", rule, {
code: 'element.style.height = "800px";',
},
{
code: `element.style.height = "800px";
element2.style.width = "800px";`,
code: `
element.style.height = "800px";
element2.style.width = "800px";
`,
},
{
code: `element.style.height = "800px";
code: `
element.style.height = "800px";
function a() { element.style.width = "800px"; }
`,
},
],

invalid: [
{
code: `function a(element){
element.style.height = "800px";
element.style.width = "800px";
}`,
code: `
function a(element){
element.style.height = "800px";
element.style.width = "800px";
}
`,
errors: [expectedError],
},
{
code: `element.style.height = "800px";
element.style.width = "800px";`,
code: `
element.style.height = "800px";
element.style.width = "800px";
`,
errors: [expectedError],
},
{
Expand Down