[ISSUE 21] keep EC69 depreciation

Author: dedece35

CHANGELOG.md

@@ -13,8 +13,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- [#22](https://github.com/green-code-initiative/ecoCode-python/issues/22) Depreciation of EC69 rule for python because not relevant (after analysis)
+
 ### Deleted
 
+- [#22](https://github.com/green-code-initiative/ecoCode-python/issues/22) Delete deprecated EC66 rule for Python
+
 ## [1.4.3] - 2024-05-15
 
 ### Added
@@ -27,9 +31,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - [#17](https://github.com/green-code-initiative/ecoCode-python/issues/17) EC7 - correction setter problem on constructor method
 - check Sonarqube 10.4.1 compatibility + update docker files and README.md / NOT OK with 10.5.x (issue created)
 
-- [#4](https://github.com/green-code-initiative/ecoCode-python/issues/4) Deprecate rule EC66 for Python because not applicable (see details inside issue)
-- [#21](https://github.com/green-code-initiative/ecoCode-python/issues/21) Deletion of EC69 for python because not relevant (after analysis)
-
 ## [1.4.2] - 2024-01-11
 
 ### Changed

src/main/java/fr/greencodeinitiative/python/checks/NoFunctionCallWhenDeclaringForLoop.java

@@ -0,0 +1,46 @@
+/*
+ * ecoCode - Python language - Provides rules to reduce the environmental footprint of your Python programs
+ * Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+package fr.greencodeinitiative.python.checks;
+
+import org.sonar.check.Rule;
+import org.sonar.plugins.python.api.PythonSubscriptionCheck;
+import org.sonar.plugins.python.api.tree.CallExpression;
+import org.sonar.plugins.python.api.tree.Tree;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
+
+/**
+ * @deprecated not applicable for Python
+ * (check discussion inside issue https://github.com/green-code-initiative/ecoCode-python/issues/21)
+ */
+@Deprecated(forRemoval = true)
+@Rule(key = "EC69")
+@DeprecatedRuleKey(repositoryKey = "gci-python", ruleKey = "S69")
+public class NoFunctionCallWhenDeclaringForLoop extends PythonSubscriptionCheck {
+
+    public static final String DESCRIPTION = "Do not call a function when declaring a for-type loop";
+
+    @Override
+    public void initialize(Context context) {
+        context.registerSyntaxNodeConsumer(Tree.Kind.CALL_EXPR, ctx -> {
+            CallExpression callExpression = (CallExpression) ctx.syntaxNode();
+            if (callExpression.parent().getKind() == Tree.Kind.FOR_STMT) {
+                ctx.addIssue(callExpression, NoFunctionCallWhenDeclaringForLoop.DESCRIPTION);
+            }
+        });
+    }
+}

src/test/java/fr/greencodeinitiative/python/PythonRuleRepositoryTest.java

@@ -78,7 +78,7 @@ void testMetadata() {
 
   @Test
   void testRegistredRules() {
-    assertThat(repository.rules()).hasSize(12);
+    assertThat(repository.rules()).hasSize(10);
   }
 
   @Test

src/test/java/fr/greencodeinitiative/python/checks/NoFunctionCallWhenDeclaringForLoopTest.java

@@ -0,0 +1,29 @@
+/*
+ * ecoCode - Python language - Provides rules to reduce the environmental footprint of your Python programs
+ * Copyright © 2023 Green Code Initiative (https://www.ecocode.io)
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+package fr.greencodeinitiative.python.checks;
+
+import org.junit.Test;
+import org.sonar.python.checks.utils.PythonCheckVerifier;
+
+@Deprecated
+public class NoFunctionCallWhenDeclaringForLoopTest {
+    @Test
+    public void test() {
+        PythonCheckVerifier.verify("src/test/resources/checks/noFunctionCallWhenDeclaringForLoop.py", new NoFunctionCallWhenDeclaringForLoop());
+    }
+}

src/test/resources/checks/noFunctionCallWhenDeclaringForLoop.py

@@ -0,0 +1,9 @@
+def my_function():
+    return 6
+
+for i in my_function(): # Noncompliant {{Do not call a function when declaring a for-type loop}}
+    print("Test")
+    my_function()
+    pass
+
+my_function()