GCI108 PreferAppendLeft fix: change rule number (97->108), apply copilot suggestion, add IT

Co-authored-by: DataLabGroupe-CreditAgricole <[email protected]>

Author: cleophass

src/it/java/org/greencodeinitiative/creedengo/python/integration/tests/GCIRulesIT.java

@@ -414,4 +414,19 @@ void testGCI107(){
         checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_10MIN);
     }
 
+    @Test
+    void testGCI108(){
+        String filePath = "src/preferAppendLeft.py";
+        String ruleId = "creedengo-python:GCI108";
+        String ruleMsg = "Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list";
+        int[] startLines = new int[]{
+            5, 8, 11, 14, 17, 20, 23, 25, 31, 35, 42
+        };
+        int[] endLines = new int[]{
+            5, 8, 11, 14, 17, 20, 23, 25, 31, 35, 42
+        };
+
+        checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_10MIN);
+    }
+
 }

src/it/test-projects/creedengo-python-plugin-test-project/src/preferAppendLeft.py

@@ -0,0 +1,61 @@
+from collections import deque
+
+# Cas non conformes
+numbers = []
+numbers.insert(0, val)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+items = []
+items.insert(0, "start")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+lst = []
+(lst).insert(0, 'x')  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+x = []
+(x).insert(0, value)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+def insert_first(l, v):
+    l.insert(0, v)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+some_list = []
+some_list.insert(index=0, object=val)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+deque_like = []
+deque_like.insert(0, "bad")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+[1, 2, 3].insert(0, 9)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+class MyList(list):
+    pass
+
+custom_list = MyList()
+custom_list.insert(0, 'z')  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+def wrapper():
+    lst = []
+    lst.insert(0, "wrapped")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+
+dq = deque()
+dq.appendleft("start")
+
+mylist = []
+mylist.insert(0.0, val) # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+
+data = []
+data.insert(1, "something")
+
+real_deque = deque()
+real_deque.appendleft("good")
+
+
+other_list = []
+position = 1
+other_list.insert(position, "ok")
+
+
+
+val = "new"
+queue = deque()
+queue.appendleft(val)
+

src/main/java/org/greencodeinitiative/creedengo/python/checks/PreferAppendLeft.java

@@ -31,7 +31,7 @@
 import static org.sonar.plugins.python.api.tree.Tree.Kind.*;
 
 
-@Rule(key = "GCI97")
+@Rule(key = "GCI108")
 public class PreferAppendLeft extends PythonSubscriptionCheck {
     public static final String DESCRIPTION = "Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list";
 
@@ -50,10 +50,13 @@ private void visitCallExpression(SubscriptionContext context) {
                 if (arguments.size() >= 2) {
                     Expression firstArg;
                     firstArg = ((RegularArgument) arguments.get(0)).expression();
-                    if (firstArg.is(NUMERIC_LITERAL)) {
-                        if (isZeroLiteral(firstArg)) {
-                        context.addIssue(callExpression, DESCRIPTION);
-                    }   
+                     if (arguments.get(0) instanceof RegularArgument) {
+                        firstArg = ((RegularArgument) arguments.get(0)).expression();
+                            if (firstArg.is(NUMERIC_LITERAL)) {
+                                if (isZeroLiteral(firstArg)) {
+                                    context.addIssue(callExpression, DESCRIPTION);
+                                }
+                            }
                     }
                 }
             }
@@ -64,7 +67,11 @@ private boolean isZeroLiteral(Expression expression) {
         if (expression.is(NUMERIC_LITERAL)) {
             NumericLiteral numericLiteral = (NumericLiteral) expression;
             String value = numericLiteral.valueAsString();
-            return "0".equals(value) || "0.0".equals(value) || "0.00".equals(value);
+            try {
+                return Double.parseDouble(value) == 0.0;
+            } catch (NumberFormatException e) {
+                return false;
+            }
         }
         return false;
     }

src/main/resources/org/greencodeinitiative/creedengo/python/creedengo_way_profile.json

@@ -19,6 +19,7 @@
 		"GCI105",
 		"GCI106",
 		"GCI107",
+		"GCI108",
 		"GCI203",
 		"GCI404"
 	]