GCI97 OptimizeSquareComputation update: add integrations/real tests

Co-authored-by: DataLabGroupe-CreditAgricole <[email protected]>

Author: cleophass

CHANGELOG.md

@@ -9,7 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Add rule GCI99 Optimize square computation (scalar vs vectorized method)
+- Add rule GCI97 Optimize square computation (scalar vs vectorized method)
+- Add rule GCI97 units tests
+- Add rule GCI97 integration tests
 
 ### Changed
 

src/it/java/org/greencodeinitiative/creedengo/python/integration/tests/GCIRulesIT.java

@@ -273,4 +273,19 @@ void testGCI203_compliant() {
 
     }
 
+    @Test
+    void testGCI97(){
+        String filePath = "src/optimizeSquareComputation.py";
+        String ruleId = "creedengo-python:GCI97";
+        String ruleMsg = "Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value";
+        int[] startLines = new int[]{
+            4, 7, 19, 20, 25, 26, 31, 38
+        };
+        int[] endLines = new int[]{
+            4, 7, 19, 20, 25, 26, 31, 38
+        };
+
+        checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_1MIN);
+    }
+
 }

src/it/test-projects/creedengo-python-plugin-test-project/src/optimizeSquareComputation.py

@@ -0,0 +1,42 @@
+import math
+
+x = 5
+result1 = x**2  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+
+z = 7
+result4 = math.pow(z, 2)  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+
+a = 3
+result5 = a*a
+
+b = 4
+result6 = b*3 
+result7 = 5*b 
+result8 = math.pow(b, 3) 
+result9 = b**3 
+
+c = 2.5
+result10 = c**2  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+result11 = math.pow(c, 2)  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+
+
+d = 8
+e = 9
+result12 = math.pow(d+e, 2)  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+result13 = (d+e)**2  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+result14 = (d+e)*(d+e) 
+
+
+def square(x):
+    return x**2  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+
+def better_square(x):
+    return x*x
+
+
+import math as m
+result15 = m.pow(d, 2)  # Noncompliant {{Use x*x instead of x**2 or math.pow(x,2) to calculate the square of a value}}
+
+result16 = math.sqrt(d)
+result17 = math.sin(d)
+result18 = math.pow(d, 1.5)

src/main/resources/org/greencodeinitiative/creedengo/python/creedengo_way_profile.json

@@ -11,6 +11,7 @@
 		"GCI74",
 		"GCI89",
 		"GCI203",
-		"GCI404"
+		"GCI404",
+		"GCI97"
   ]
 }