after merging GCI99, correction of small review feedbacks

Author: dedece35

src/it/java/org/greencodeinitiative/creedengo/python/integration/tests/GCIRulesIT.java

@@ -302,6 +302,21 @@ void testGCI97(){
 
         checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_1MIN);
     }
+
+    @Test
+    void testGCI99(){
+        String filePath = "src/avoidCSVFormat.py";
+        String ruleId = "creedengo-python:GCI99";
+        String ruleMsg = "Use Parquet or Feather format instead of CSV";
+        int[] startLines = new int[]{
+                4, 6, 10, 12, 14, 15, 17, 18, 23, 39, 47, 48
+        };
+        int[] endLines = new int[]{
+                4, 6, 10, 12, 14, 15, 17, 18, 23, 39, 47, 48
+        };
+
+        checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_50MIN);
+    }
 
     @Test
     void testGCI103(){
@@ -320,21 +335,6 @@ void testGCI103(){
 
     }
 
-    @Test
-    void testGCI99(){
-        String filePath = "src/avoidCSVFormat.py";
-        String ruleId = "creedengo-python:GCI99";
-        String ruleMsg = "Use Parquet or Feather format instead of CSV";
-        int[] startLines = new int[]{
-            4, 6, 10, 12, 14, 15, 17, 18, 23, 39, 47, 48
-        };
-        int[] endLines = new int[]{
-            4, 6, 10, 12, 14, 15, 17, 18, 23, 39, 47, 48
-        };
-
-        checkIssuesForFile(filePath, ruleId, ruleMsg, startLines, endLines, SEVERITY, TYPE, EFFORT_50MIN);
-    }
-
     @Test
     void testGCI106() {
         String filePath = "src/avoidSqrtInLoop.py";

src/main/java/org/greencodeinitiative/creedengo/python/checks/AvoidCSVFormat.java

@@ -27,7 +27,6 @@
 
 import java.util.HashSet;
 import java.util.Set;
-import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
 import org.sonar.plugins.python.api.PythonSubscriptionCheck;
@@ -36,7 +35,7 @@
 public class AvoidCSVFormat extends PythonSubscriptionCheck {
 
     public static final String DESCRIPTION = "Use Parquet or Feather format instead of CSV";
-    protected static final Pattern CSV_EXTENSION = Pattern.compile("\\.csv");
+    protected static final Pattern CSV_EXTENSION = Pattern.compile("\\.csv$", Pattern.CASE_INSENSITIVE);
     private final Set<Integer> reportedLines = new HashSet<>();
 
     @Override
@@ -53,7 +52,7 @@ public void visitCallExpression(SubscriptionContext ctx) {
             QualifiedExpression qualifiedExpression = (QualifiedExpression) callee;
             String methodName = qualifiedExpression.name().name();
 
-            if (methodName.equals("read_csv") || methodName.equals("to_csv")) {
+            if ("read_csv".equals(methodName) || "to_csv".equals(methodName)) {
                 int line = callExpression.firstToken().line();
 
                 if (!reportedLines.contains(line)) {
@@ -71,10 +70,8 @@ public void visitNodeString(SubscriptionContext ctx) {
         if (reportedLines.contains(line)) {
             return;
         }
-        String strValue = stringLiteral.trimmedQuotesValue();
-        Matcher matcher = CSV_EXTENSION.matcher(strValue);
 
-        if (matcher.find()) {
+        if (CSV_EXTENSION.matcher(stringLiteral.trimmedQuotesValue()).find()) {
             reportedLines.add(line);
             ctx.addIssue(stringLiteral, DESCRIPTION);
         }