Skip to content

Commit 761ce46

Browse files
committed
[ISSUE 123] complete unit tests for EC7 rule
1 parent 7b1463e commit 761ce46

File tree

3 files changed

+28
-1
lines changed

3 files changed

+28
-1
lines changed

src/test/java/fr/greencodeinitiative/python/checks/AvoidGettersAndSettersTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public class AvoidGettersAndSettersTest {
2424

2525
@Test
2626
public void test() {
27-
PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSetters.py", new AvoidGettersAndSetters());
27+
PythonCheckVerifier.verifyNoIssue("src/test/resources/checks/avoidGettersAndSettersCompliant.py", new AvoidGettersAndSetters());
28+
PythonCheckVerifier.verify("src/test/resources/checks/avoidGettersAndSettersNonCompliant.py", new AvoidGettersAndSetters());
2829
}
2930
}
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
from datetime import date
2+
3+
class Client():
4+
5+
def __init__(self, age, weight):
6+
self.age = age
7+
self.weight = weight
8+
9+
def get_age_in_five_years(self):
10+
a = Client()
11+
return a.age
12+
13+
def is_major(self):
14+
return self.age >= 18
15+
16+
client = Client(25)
17+
client.age
18+
client.age = 25
19+
client.weight
20+
client.weight(5)

src/test/resources/checks/avoidGettersAndSetters.py renamed to src/test/resources/checks/avoidGettersAndSettersNonCompliant.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,9 @@ def is_major(self):
2424

2525
def get_weight(self): # Noncompliant {{Avoid creating getter and setter methods in classes}}
2626
return self.weight
27+
28+
client = Client(25)
29+
client.get_age()
30+
client.set_age(25)
31+
client.get_weight()
32+
client.set_weight(5)

0 commit comments

Comments
 (0)