correction after GCI108 merging

Author: dedece35

CHANGELOG.md

@@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- [#70](https://github.com/green-code-initiative/creedengo-python/pull/70) Add rule GCI97 Prefer Append Left (a rule to prefer the use of `append` over `insert` for list, using deques)
+- [#70](https://github.com/green-code-initiative/creedengo-python/pull/70) Add rule GCI108 Prefer Append Left (a rule to prefer the use of `append` over `insert` for list, using deques)
 - [#78](https://github.com/green-code-initiative/creedengo-python/pull/78) Add rule GCI105 on String Concatenation. This rule may also apply to other rules
 - [#74](https://github.com/green-code-initiative/creedengo-python/pull/74) Add rule GCI101 Avoid Conv Bias Before Batch Normalization, a rule specific to Deeplearning
 - [#75](https://github.com/green-code-initiative/creedengo-python/pull/75) Add rule GCI102 avoid non pinned memory for dataloader. This rule is specific to PyTorch and so AI

src/main/java/org/greencodeinitiative/creedengo/python/checks/PreferAppendLeft.java

@@ -30,9 +30,9 @@
 
 import static org.sonar.plugins.python.api.tree.Tree.Kind.*;
 
-
 @Rule(key = "GCI108")
 public class PreferAppendLeft extends PythonSubscriptionCheck {
+
     public static final String DESCRIPTION = "Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list";
 
     @Override
@@ -44,19 +44,12 @@ private void visitCallExpression(SubscriptionContext context) {
         CallExpression callExpression = (CallExpression) context.syntaxNode();
         if (callExpression.callee().is(QUALIFIED_EXPR)) {
             QualifiedExpression qualifiedExpression = (QualifiedExpression) callExpression.callee();
-            
             if (qualifiedExpression.name().name().equals("insert")) {
                 List<org.sonar.plugins.python.api.tree.Argument> arguments = callExpression.arguments();
-                if (arguments.size() >= 2) {
-                    Expression firstArg;
-                    firstArg = ((RegularArgument) arguments.get(0)).expression();
-                     if (arguments.get(0) instanceof RegularArgument) {
-                        firstArg = ((RegularArgument) arguments.get(0)).expression();
-                            if (firstArg.is(NUMERIC_LITERAL)) {
-                                if (isZeroLiteral(firstArg)) {
-                                    context.addIssue(callExpression, DESCRIPTION);
-                                }
-                            }
+                if (arguments.size() >= 2 && arguments.get(0) instanceof RegularArgument) {
+                    Expression firstArg = ((RegularArgument) arguments.get(0)).expression();
+                    if (firstArg.is(NUMERIC_LITERAL) && isZeroLiteral(firstArg)) {
+                        context.addIssue(callExpression, DESCRIPTION);
                     }
                 }
             }