Skip to content

Commit 8dd9fda

Browse files
committed
[ISSUE 142] optim enum values
1 parent 6bf103e commit 8dd9fda

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/main/java/fr/greencodeinitiative/python/checks/AvoidMultipleIfElseStatementCheck.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
import org.sonar.plugins.python.api.tree.IfStatement;
3434
import org.sonar.plugins.python.api.tree.Statement;
3535
import org.sonar.plugins.python.api.tree.Tree;
36-
import static org.sonar.plugins.python.api.tree.Tree.Kind.FUNCDEF;
36+
import static org.sonar.plugins.python.api.tree.Tree.Kind.*;
3737

3838
/**
3939
* FUNCTIONAL DESCRIPTION : please see ASCIIDOC description file of this rule (inside `ecocode-rules-spcifications`)
@@ -95,7 +95,7 @@ private void visitNodeContent(SubscriptionContext context, List<Statement> pLstS
9595
// // the cirrent node is a block : visit block content
9696
// visitNodeContent(((BlockTree)statement).statements(), pLevel);
9797
// } else
98-
if (statement.is(Tree.Kind.IF_STMT)) {
98+
if (statement.is(IF_STMT)) {
9999
visitIfNode(context, (IfStatement)statement, pLevel);
100100
}
101101
}
@@ -158,14 +158,14 @@ private void computeIfVariables(SubscriptionContext context, IfStatement pIfTree
158158
private void computeConditionVariables(SubscriptionContext context, BinaryExpression pBinExprTree, int pLevel) {
159159

160160
// if multiple conditions, continue with each part of complex expression
161-
if (pBinExprTree.is(Tree.Kind.AND) || pBinExprTree.is(Tree.Kind.OR)) {
161+
if (pBinExprTree.is(AND) || pBinExprTree.is(OR)) {
162162
if (pBinExprTree.leftOperand() instanceof BinaryExpression) {
163163
computeConditionVariables(context, (BinaryExpression) pBinExprTree.leftOperand(), pLevel);
164164
}
165165
if (pBinExprTree.rightOperand() instanceof BinaryExpression) {
166166
computeConditionVariables(context, (BinaryExpression) pBinExprTree.rightOperand(), pLevel);
167167
}
168-
} else if (pBinExprTree.is(Tree.Kind.COMPARISON)) {
168+
} else if (pBinExprTree.is(COMPARISON)) {
169169
// else if (pBinExprTree.is(Tree.Kind.EQUAL_TO)
170170
// || pBinExprTree.is(Tree.Kind.NOT_EQUAL_TO)
171171
// || pBinExprTree.is(Tree.Kind.GREATER_THAN)

0 commit comments

Comments
 (0)