GCI97 Add unit tests and detect 0.0 and 0.00 case

Co-authored-by: DataLabGroupe-CreditAgricole <[email protected]>

Author: cleophass

src/main/java/org/greencodeinitiative/creedengo/python/checks/PreferAppendLeft.java

@@ -30,6 +30,7 @@
 
 import static org.sonar.plugins.python.api.tree.Tree.Kind.*;
 
+
 @Rule(key = "GCI97")
 public class PreferAppendLeft extends PythonSubscriptionCheck {
     public static final String DESCRIPTION = "Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list";
@@ -41,21 +42,18 @@ public void initialize(Context context) {
 
     private void visitCallExpression(SubscriptionContext context) {
         CallExpression callExpression = (CallExpression) context.syntaxNode();
-
         if (callExpression.callee().is(QUALIFIED_EXPR)) {
             QualifiedExpression qualifiedExpression = (QualifiedExpression) callExpression.callee();
-
-            
 
             if (qualifiedExpression.name().name().equals("insert")) {
                 List<org.sonar.plugins.python.api.tree.Argument> arguments = callExpression.arguments();
-                
-                if (arguments.size() >= 2) {// because it should be like insert(0,val) so there's two arguments
+                if (arguments.size() >= 2) {
                     Expression firstArg;
                     firstArg = ((RegularArgument) arguments.get(0)).expression();
-             
-                    if (isZeroLiteral(firstArg)) {
+                    if (firstArg.is(NUMERIC_LITERAL)) {
+                        if (isZeroLiteral(firstArg)) {
                         context.addIssue(callExpression, DESCRIPTION);
+                    }   
                     }
                 }
             }
@@ -66,7 +64,7 @@ private boolean isZeroLiteral(Expression expression) {
         if (expression.is(NUMERIC_LITERAL)) {
             NumericLiteral numericLiteral = (NumericLiteral) expression;
             String value = numericLiteral.valueAsString();
-            return "0".equals(value);
+            return "0".equals(value) || "0.0".equals(value) || "0.00".equals(value);
         }
         return false;
     }

src/test/resources/checks/preferAppendLeft.py

@@ -1,23 +1,12 @@
 from collections import deque
 
+# Cas non conformes
 numbers = []
 numbers.insert(0, val)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
 items = []
 items.insert(0, "start")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
-mylist = []
-mylist.insert(0.0, val)  
-
-a = 0
-mylist.insert(a, val)  
-
-dq = deque()
-dq.appendleft("start") 
-
-data = []
-data.insert(1, "something")  
-
 lst = []
 (lst).insert(0, 'x')  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
@@ -27,19 +16,46 @@
 def insert_first(l, v):
     l.insert(0, v)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
-def add_to_front(dq, item):
-    dq.appendleft(item) 
-
 some_list = []
-some_list.insert(index=0, object=val)   # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+some_list.insert(index=0, object=val)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
 deque_like = []
 deque_like.insert(0, "bad")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
 
+[1, 2, 3].insert(0, 9)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+class MyList(list):
+    pass
+
+custom_list = MyList()
+custom_list.insert(0, 'z')  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+def wrapper():
+    lst = []
+    lst.insert(0, "wrapped")  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+
+dq = deque()
+dq.appendleft("start")
+
+mylist = []
+mylist.insert(0.0, val) # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+
+
+data = []
+data.insert(1, "something")
+
 real_deque = deque()
-real_deque.appendleft("good")  
+real_deque.appendleft("good")
 
-fn = getattr(mylist, "insert")
-fn(0, val) 
 
-[1, 2, 3].insert(0, 9)  # Noncompliant {{Use appendleft with deque instead of .insert(0, val) for modification at the beginning of a list}}
+other_list = []
+position = 1
+other_list.insert(position, "ok")
+
+
+
+val = "new"
+queue = deque()
+queue.appendleft(val)
+