Skip to content

Commit f34a5f8

Browse files
committed
[PR 128-ecocode] replace EC34 by EC35 : refacto naming
1 parent bcdb97a commit f34a5f8

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public List<Class> checkClasses() {
5959
AvoidGettersAndSetters.class,
6060
AvoidGlobalVariableInFunctionCheck.class,
6161
AvoidSQLRequestInLoop.class,
62-
AvoidTryCatchFileOpenCheck.class,
62+
AvoidTryCatchWithFileOpenedCheck.class,
6363
AvoidUnoptimizedVectorImagesCheck.class,
6464
NoFunctionCallWhenDeclaringForLoop.class,
6565
AvoidFullSQLRequest.class,

src/main/java/fr/greencodeinitiative/python/checks/AvoidTryCatchFileOpenCheck.java renamed to src/main/java/fr/greencodeinitiative/python/checks/AvoidTryCatchWithFileOpenedCheck.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,16 +24,12 @@
2424
import org.sonar.plugins.python.api.tree.*;
2525
import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
2626

27-
import java.util.List;
28-
import java.util.Objects;
29-
3027
import static org.sonar.plugins.python.api.tree.Tree.Kind.CALL_EXPR;
31-
import static org.sonar.plugins.python.api.tree.Tree.Kind.LIST_COMPREHENSION;
3228

3329
@Rule(key = "EC35")
3430
@DeprecatedRuleKey(repositoryKey = "gci-python", ruleKey = "S34")
3531
@DeprecatedRuleKey(repositoryKey = "gci-python", ruleKey = "EC34")
36-
public class AvoidTryCatchFileOpenCheck extends PythonSubscriptionCheck {
32+
public class AvoidTryCatchWithFileOpenedCheck extends PythonSubscriptionCheck {
3733

3834
public static final String DESCRIPTION = "Avoid the use of try-catch with a file open in try block";
3935

src/test/java/fr/greencodeinitiative/python/checks/AvoidTryCatchFinallyCheckTest.java renamed to src/test/java/fr/greencodeinitiative/python/checks/AvoidTryCatchWithFileOpenedCheckTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@
2121
import org.junit.Test;
2222
import org.sonar.python.checks.utils.PythonCheckVerifier;
2323

24-
public class AvoidTryCatchFinallyCheckTest {
24+
public class AvoidTryCatchWithFileOpenedCheckTest {
2525
@Test
2626
public void test() {
27-
PythonCheckVerifier.verify("src/test/resources/checks/avoidTryCatchWithFileOpenCheck.py", new AvoidTryCatchFileOpenCheck());
27+
PythonCheckVerifier.verify("src/test/resources/checks/avoidTryCatchWithFileOpenedCheck.py", new AvoidTryCatchWithFileOpenedCheck());
2828
}
2929
}

0 commit comments

Comments
 (0)