[ISSUE 21] delete irrelevant EC69 + delete deprecated EC66 + update sonarqube support to 10.4.1

Author: dedece35

CHANGELOG.md

@@ -10,13 +10,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 
 - [#18](https://github.com/green-code-initiative/ecoCode-python/issues/18) Add support for SonarQube 10.4 "DownloadOnlyWhenRequired" feature
+- Add Support for SonarQube 10.4.1
 
 ### Changed
 
 - [#17](https://github.com/green-code-initiative/ecoCode-python/issues/17) EC7 - correction setter problem on constructor method
 
 ### Deleted
 
+- [#4](https://github.com/green-code-initiative/ecoCode-python/issues/4) Deprecate rule EC66 for Python because not applicable (see details inside issue)
+- [#21](https://github.com/green-code-initiative/ecoCode-python/issues/21) Deletion of EC69 for python because not relevant (after analysis)
+
 ## [1.4.2] - 2024-01-11
 
 ### Changed

README.md

@@ -63,9 +63,9 @@ Ready to use binaries are available [from GitHub](https://github.com/green-code-
 🧩 Compatibility
 ------------------
 
-| Plugin version | SonarQube version | Java version |
-|----------------|-------------------|--------------|
-| 1.4.+          | 9.4.+ LTS to 10.3 | 11 / 17      |
+| Plugin version | SonarQube version   | Java version |
+|----------------|---------------------|--------------|
+| 1.4.+          | 9.4.+ LTS to 10.4.1 | 11 / 17      |
 
 > Compatibility table of versions lower than 1.4.+ are available from the
 > main [ecoCode repository](https://github.com/green-code-initiative/ecoCode#-plugins-version-compatibility).

docker-compose.yml

@@ -1,7 +1,7 @@
 version: "3.3"
 services:
   sonar:
-    image: sonarqube:10.3.0-community
+    image: sonarqube:10.4.1-community
     container_name: sonar_ecocode_python
     ports:
       - "9000:9000"

pom.xml

@@ -59,7 +59,7 @@
         <mockito.version>5.3.1</mockito.version>
 
         <!-- temporary version waiting for real automatic release in ecocode repository -->
-        <ecocode-rules-specifications.version>1.4.7</ecocode-rules-specifications.version>
+        <ecocode-rules-specifications.version>1.5.0</ecocode-rules-specifications.version>
 
         <sonar-analyzer-commons.version>2.5.0.1358</sonar-analyzer-commons.version>
 

src/main/java/fr/greencodeinitiative/python/PythonRuleRepository.java

@@ -55,13 +55,11 @@ public String repositoryKey() {
   @Override
   public List<Class> checkClasses() {
     return Arrays.asList(
-            AvoidDoubleQuoteCheck.class,
             AvoidGettersAndSetters.class,
             AvoidGlobalVariableInFunctionCheck.class,
             AvoidSQLRequestInLoop.class,
             AvoidTryCatchWithFileOpenedCheck.class,
             AvoidUnoptimizedVectorImagesCheck.class,
-            NoFunctionCallWhenDeclaringForLoop.class,
             AvoidFullSQLRequest.class,
             AvoidListComprehensionInIterations.class,
             DetectUnoptimizedImageFormat.class,

src/main/java/fr/greencodeinitiative/python/checks/AvoidDoubleQuoteCheck.java

@@ -78,7 +78,7 @@ void testMetadata() {
 
   @Test
   void testRegistredRules() {
-    assertThat(repository.rules()).hasSize(11);
+    assertThat(repository.rules()).hasSize(9);
   }
 
   @Test