-
Notifications
You must be signed in to change notification settings - Fork 22
JDK11 retro-compatibility #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR downgrades the project from Java 17 to Java 11 for backward compatibility. The changes primarily replace pattern matching syntax introduced in Java 17 with traditional instanceof checks and casting.
- Replaces Java 17 pattern matching with traditional instanceof checks and explicit casting
- Updates Java version from 17 to 11 across configuration files
- Downgrades SonarQube version and license plugin version for Java 11 compatibility
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/greencodeinitiative/creedengo/python/utils/UtilsAST.java | Replaces pattern matching instanceof with traditional instanceof and casting |
| src/main/java/org/greencodeinitiative/creedengo/python/checks/DictionaryItemsUnused.java | Replaces pattern matching instanceof with traditional instanceof and casting |
| src/it/test-projects/creedengo-python-plugin-test-project/pom.xml | Updates Java version from 17 to 11 |
| pom.xml | Updates Java version, SonarQube version, and license plugin version for Java 11 compatibility |
| Dockerfile | Updates Maven builder and SonarQube version for Java 11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
converted to draft waiting for core-team decision if we keep JDK11 compatibility |
|
This PR has been automatically marked as stale because it has no activity for 30 days. |



No description provided.