Skip to content

Conversation

@dedece35
Copy link
Member

No description provided.

@dedece35 dedece35 requested a review from Copilot August 30, 2025 17:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR downgrades the project from Java 17 to Java 11 for backward compatibility. The changes primarily replace pattern matching syntax introduced in Java 17 with traditional instanceof checks and casting.

  • Replaces Java 17 pattern matching with traditional instanceof checks and explicit casting
  • Updates Java version from 17 to 11 across configuration files
  • Downgrades SonarQube version and license plugin version for Java 11 compatibility

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/org/greencodeinitiative/creedengo/python/utils/UtilsAST.java Replaces pattern matching instanceof with traditional instanceof and casting
src/main/java/org/greencodeinitiative/creedengo/python/checks/DictionaryItemsUnused.java Replaces pattern matching instanceof with traditional instanceof and casting
src/it/test-projects/creedengo-python-plugin-test-project/pom.xml Updates Java version from 17 to 11
pom.xml Updates Java version, SonarQube version, and license plugin version for Java 11 compatibility
Dockerfile Updates Maven builder and SonarQube version for Java 11

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@dedece35 dedece35 self-assigned this Aug 31, 2025
@dedece35 dedece35 added 🏗️ refactoring refactoring for best practices 🔥 in progress 🔥 🚀 enhancement New feature or request labels Aug 31, 2025
@sonarqubecloud
Copy link

@dedece35 dedece35 marked this pull request as draft September 12, 2025 14:55
@dedece35
Copy link
Member Author

converted to draft waiting for core-team decision if we keep JDK11 compatibility

@github-actions
Copy link

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏗️ refactoring refactoring for best practices 🔥 in progress 🔥 🚀 enhancement New feature or request stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants