Skip to content

Conversation

@Geenag
Copy link

@Geenag Geenag commented May 21, 2025

Create new Javascript Rule to optimize browserlist tag (GCI1234)

@MP-Aubay MP-Aubay changed the title GCI1234 Optimize browserlist tag in package.json #Javascript #RulesSpecifications #TERRE GCI1234 [Team TERRE][2025] - Optimize browserlist tag in package.json #Javascript #RulesSpecifications May 21, 2025
@MP-Aubay MP-Aubay self-assigned this May 21, 2025
Copy link
Contributor

@MP-Aubay MP-Aubay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, do not forget to update CHANGELOG.md.

About this rule, as you said for "Internet", browserslist should be "defaults", so there will be many false positives, and I think there is no way to avoid it.

@utarwyn : what's your point view on this ?

@Geenag
Copy link
Author

Geenag commented May 30, 2025

Changelog updated

About the false positives, if you mean that the value "defaults" on internet apps will uselessly raise the rule, our idea is to implement a rule where "browserslist" mention in package.json could be good enough. This way, rule will only be raised by apps where devs have not at all taken in consideration the "browserslist" tag.

@Rdulieu
Copy link

Rdulieu commented Jun 6, 2025

Actually our main goal was to set developpers to think about their target browsers. I think defaults should not be compliant with the rule because it's probably here when developers didn't really think about it and add browserlist anyway.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

This PR has been automatically marked as stale because it has no activity for 60 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants