Merge pull request #74 from jhertout/groovy_rules_nomenclature

jhertout · web-flow · commit 0af75b4cab93 · 2023-10-12T14:51:42.000+02:00
Groovy rules nomenclature
diff --git a/android-plugin/pom.xml b/android-plugin/pom.xml
@@ -184,7 +184,7 @@
 		<dependency>
 			<groupId>org.codenarc</groupId>
 			<artifactId>CodeNarc</artifactId>
-			<version>2.2.3</version>
+			<version>2.2.4</version>
 		</dependency>
 
 		<dependency>
diff --git a/android-plugin/src/main/java/org/sonar/plugins/groovy/codenarc/CodeNarcRulesDefinition.java b/android-plugin/src/main/java/org/sonar/plugins/groovy/codenarc/CodeNarcRulesDefinition.java
@@ -34,9 +34,8 @@
 
 public class CodeNarcRulesDefinition implements RulesDefinition {
 
-  // TODO: Prefix repository-key with "ecocode-" and make "re-keying" of all contained rules
-  public static final String REPOSITORY_KEY = Groovy.KEY;
-  public static final String REPOSITORY_NAME = "ecoCode";
+  public static final String REPOSITORY_KEY = "ecocode-android-groovy";
+  public static final String REPOSITORY_NAME = Groovy.PROFILE_NAME;
   private static final String COST_FILE_PATH = "/org/sonar/plugins/groovy/cost.csv";
 
   @Override
diff --git a/android-plugin/src/main/java/org/sonar/plugins/groovy/foundation/Groovy.java b/android-plugin/src/main/java/org/sonar/plugins/groovy/foundation/Groovy.java
@@ -31,7 +31,7 @@ public class Groovy extends AbstractLanguage {
 
   public static final String KEY = "grvy";
   public static final String NAME = "Groovy";
-  public static final String PROFILE_NAME = "ecoCode";
+  public static final String PROFILE_NAME = "ecoCode (Android)";
   public static final String FILE_SUFFIXES_KEY = "sonar.groovy.file.suffixes";
   static final String DEFAULT_FILE_SUFFIXES = ".groovy,.gradle";
 
diff --git a/android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv b/android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv
@@ -1,4 +1,4 @@
 ruleKey;remediationFunction;remediationFactor
-org.codenarc.rule.ecocode.FatAppRule;linear;1h
-org.codenarc.rule.ecocode.SupportedVersionRangeRule;linear;10min
-org.codenarc.rule.ecocode.DisableObfuscationRule;linear;10min
+EC5001;linear;1h
+EC5002;linear;10min
+EC5003;linear;10min
diff --git a/android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt b/android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt
@@ -1,3 +1,3 @@
-org.codenarc.rule.ecocode.FatAppRule
-org.codenarc.rule.ecocode.SupportedVersionRangeRule
-org.codenarc.rule.ecocode.DisableObfuscationRule
+EC5001
+EC5002
+EC5003
diff --git a/android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml b/android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml
@@ -4,10 +4,10 @@
 
   <!-- since 2.2.1 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.FatAppRule</key>
+    <key>EC5001</key>
     <severity>MINOR</severity>
     <name><![CDATA[Fat App]]></name>
-    <internalKey><![CDATA[FatApp]]></internalKey>
+    <internalKey><![CDATA[EC5001]]></internalKey>
     <description><![CDATA[<p>Using &quot;multiDexEnabled true&quot; goes against the overall reduction of the weight of the apps and hence must be avoided.</p>
 <p>Example of violations:</p>
 <pre><code>    android {
@@ -46,10 +46,10 @@
 
   <!-- since 2.2.1 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.SupportedVersionRangeRule</key>
+    <key>EC5002</key>
     <severity>MINOR</severity>
     <name><![CDATA[Supported Version Range]]></name>
-    <internalKey><![CDATA[SupportedVersionRange]]></internalKey>
+    <internalKey><![CDATA[EC5002]]></internalKey>
     <description><![CDATA[<p>When looking at the minSdkVersion and targetSdkVersion (or minSdk, targetSdk) attributes for the <uses-sdk> in the AndroidManifest.xml file, the amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.</p>
 <p>Example of violations:</p>
 <pre><code>android {
@@ -86,10 +86,10 @@
 
   <!-- since 2.2.3 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.DisableObfuscationRule</key>
+    <key>EC5003</key>
     <severity>MINOR</severity>
     <name><![CDATA[Disable Obfuscation]]></name>
-    <internalKey><![CDATA[DisableObfuscation]]></internalKey>
+    <internalKey><![CDATA[EC5003]]></internalKey>
     <description><![CDATA[<p>Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.</p>
 <p>Example of violations:</p>
 <pre><code>    android {
diff --git a/codenarc-converter/CodeNarc/CHANGELOG.md b/codenarc-converter/CodeNarc/CHANGELOG.md
@@ -2,6 +2,13 @@
 <!-- markdownlint-disable MD003 MD004 MD007 MD032 -->
 # CodeNarc Change Log
 
+Version 2.2.4    (September 2023)
+--------------------------------------
+Update key of ecoCode rules:
+- Fat App -> EC5001
+- Supported Version Range -> EC5002
+- Disable Obfuscation -> EC5003
+
 Version 2.2.3    (November 2022)
 --------------------------------------
 Added rule
diff --git a/codenarc-converter/CodeNarc/build.gradle b/codenarc-converter/CodeNarc/build.gradle
@@ -14,7 +14,7 @@ shadowJar {
 
 group = 'org.codenarc'
 archivesBaseName = 'CodeNarc'
-version = '2.2.3'
+version = '2.2.4'
 
 sourceCompatibility = '1.7'
 targetCompatibility = '1.7'
diff --git a/codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRules.groovy.txt b/codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRules.groovy.txt
@@ -77,7 +77,6 @@ ruleset {
     CyclomaticComplexity   // Requires the GMetrics jar
     DeadCode 
     DirectConnectionManagement
-    DisableObfuscation
     DoubleCheckedLocking 
     DoubleNegative 
     DuplicateCaseStatement 
@@ -88,6 +87,9 @@ ruleset {
     DuplicateNumberLiteral 
     DuplicateSetValue 
     DuplicateStringLiteral 
+    EC5001
+    EC5002
+    EC5003
     ElseBlockBraces 
     EmptyCatchBlock 
     EmptyClass
@@ -133,7 +135,6 @@ ruleset {
     ExplicitStackInstantiation
     ExplicitTreeSetInstantiation
     FactoryMethodName
-    FatApp
     FieldName 
     FieldTypeRequired 
     FileCreateTempFile 
@@ -304,7 +305,6 @@ ruleset {
     StaticMatcherField 
     StaticMethodsBeforeInstanceMethods 
     StaticSimpleDateFormatField
-    SupportedVersionRange
     SwallowThreadDeath 
     SynchronizedMethod 
     SynchronizedOnBoxedPrimitive 
diff --git a/codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRulesByCategory.groovy.txt b/codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRulesByCategory.groovy.txt
@@ -166,9 +166,9 @@ ruleset {
     DuplicateStringLiteral
 
     // rulesets/ecocode.xml
-    FatApp
-    SupportedVersionRange
-    DisableObfuscation
+    EC5001
+    EC5002
+    EC5003
 
     // rulesets/enhanced.xml
     CloneWithoutCloneable 
diff --git a/codenarc-converter/CodeNarc/docs/codenarc-rule-index-by-name.md b/codenarc-converter/CodeNarc/docs/codenarc-rule-index-by-name.md
@@ -79,7 +79,6 @@ title: CodeNarc - Rule Index by Name
 * [CyclomaticComplexity](./codenarc-rules-size.html#cyclomaticcomplexity-rule)    (Requires the GMetrics jar)
 * [DeadCode](./codenarc-rules-basic.html#deadcode-rule)
 * [DirectConnectionManagement](./codenarc-rules-jdbc.html#directconnectionmanagement-rule)
-* [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
 * [DoubleCheckedLocking](./codenarc-rules-concurrency.html#doublecheckedlocking-rule)
 * [DoubleNegative](./codenarc-rules-basic.html#doublenegative-rule)
 * [DuplicateCaseStatement](./codenarc-rules-basic.html#duplicatecasestatement-rule)
@@ -90,6 +89,9 @@ title: CodeNarc - Rule Index by Name
 * [DuplicateNumberLiteral](./codenarc-rules-dry.html#duplicatenumberliteral-rule)
 * [DuplicateSetValue](./codenarc-rules-basic.html#duplicatesetvalue-rule)
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
+* [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
+* [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
+* [EC5003](./codenarc-rules-ecocode.html#EC5003-rule)
 * [ElseBlockBraces](./codenarc-rules-braces.html#elseblockbraces-rule)
 * [EmptyCatchBlock](./codenarc-rules-basic.html#emptycatchblock-rule)
 * [EmptyClass](./codenarc-rules-basic.html#emptyclass-rule)
@@ -135,7 +137,6 @@ title: CodeNarc - Rule Index by Name
 * [ExplicitStackInstantiation](./codenarc-rules-groovyism.html#explicitstackinstantiation-rule)
 * [ExplicitTreeSetInstantiation](./codenarc-rules-groovyism.html#explicittreesetinstantiation-rule)
 * [FactoryMethodName](./codenarc-rules-naming.html#factorymethodname-rule)
-* [FatApp](./codenarc-rules-ecocode.html#fatapp-rule)
 * [FieldName](./codenarc-rules-naming.html#fieldname-rule)
 * [FieldTypeRequired](./codenarc-rules-convention.html#fieldtyperequired-rule)
 * [FileCreateTempFile](./codenarc-rules-security.html#filecreatetempfile-rule)
@@ -306,7 +307,6 @@ title: CodeNarc - Rule Index by Name
 * [StaticMatcherField](./codenarc-rules-concurrency.html#staticmatcherfield-rule)
 * [StaticMethodsBeforeInstanceMethods](./codenarc-rules-convention.html#staticmethodsbeforeinstancemethods-rule)
 * [StaticSimpleDateFormatField](./codenarc-rules-concurrency.html#staticsimpledateformatfield-rule)
-* [SupportedVersionRange](./codenarc-rules-ecocode.html#supportedversionrange-rule)
 * [SwallowThreadDeath](./codenarc-rules-exceptions.html#swallowthreaddeath-rule)
 * [SynchronizedMethod](./codenarc-rules-concurrency.html#synchronizedmethod-rule)
 * [SynchronizedOnBoxedPrimitive](./codenarc-rules-concurrency.html#synchronizedonboxedprimitive-rule)
diff --git a/codenarc-converter/CodeNarc/docs/codenarc-rule-index.md b/codenarc-converter/CodeNarc/docs/codenarc-rule-index.md
@@ -167,9 +167,9 @@ title: CodeNarc - Rule Index
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
 
 ## [Ecocode](./codenarc-rules-ecocode.html)
-* [FatApp](./codenarc-rules-ecocode.html#fatapp-rule)
-* [SupportedVersionRange](./codenarc-rules-ecocode.html#supportedversionrange-rule)
-* [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
+* [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
+* [EC5002](./codenarc-rules-ecocode.html#EC5002-rule)
+* [EC5003](./codenarc-rules-ecocode.html#EC5003-rule)
 
 ## [Enhanced](./codenarc-rules-enhanced.html)
 * [CloneWithoutCloneable](./codenarc-rules-enhanced.html#clonewithoutcloneable-rule)
diff --git a/codenarc-converter/CodeNarc/docs/codenarc-rules-ecocode.md b/codenarc-converter/CodeNarc/docs/codenarc-rules-ecocode.md
@@ -5,7 +5,7 @@ title: CodeNarc - Ecocode Rules
 
 # Ecocode Rules  ("*rulesets/ecocode.xml*")
 
-## FatApp Rule
+## EC5001 Rule
 
 *Since CodeNarc 2.2.1*
 
@@ -45,7 +45,7 @@ Example of violations:
     }
 ```
 
-## SupportedVersionRange Rule
+## EC5002 Rule
 
 *Since CodeNarc 2.2.1*
 
@@ -83,7 +83,7 @@ android {
 }
 ```
 
-## DisableObfuscation Rule
+## EC5003 Rule
 
 *Since CodeNarc 2.2.3*
 
@@ -119,4 +119,3 @@ Example of violations:
         }
     }
 ```
-
diff --git a/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5001.groovy b/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5001.groovy
@@ -29,14 +29,14 @@ import org.codenarc.util.AstUtil
  *
  * @author Leboulanger Mickael
  */
-class FatAppRule extends AbstractAstVisitorRule {
+class EC5001 extends AbstractAstVisitorRule {
 
-    String name = 'FatApp'
+    String name = 'EC5001'
     int priority = 2
-    Class astVisitorClass = FatAppAstVisitor
+    Class astVisitorClass = EC5001AstVisitor
 }
 
-class FatAppAstVisitor extends AbstractAstVisitor {
+class EC5001AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {
diff --git a/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5002.groovy b/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5002.groovy
@@ -26,19 +26,19 @@ import org.codenarc.util.AstUtil
  *
  * @author Leboulanger Mickael
  */
-class SupportedVersionRangeRule extends AbstractAstVisitorRule {
+class EC5002 extends AbstractAstVisitorRule {
 
-    String name = 'SupportedVersionRange'
+    String name = 'EC5002'
     int priority = 2
     int minSdkVersion = 0
     int minSdk = 0
     int targetSdkVersion = 0
     int targetSdk = 0
     int threshold = 4 // Value used to compare minSdkVersion and targetSdkVersion
-    Class astVisitorClass = SupportedVersionRangeAstVisitor
+    Class astVisitorClass = EC5002AstVisitor
 }
 
-class SupportedVersionRangeAstVisitor extends AbstractAstVisitor {
+class EC5002AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {
diff --git a/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5003.groovy b/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5003.groovy
@@ -27,14 +27,14 @@ import org.codenarc.util.AstUtil
  *
  * @author Berque Justin
  */
-class DisableObfuscationRule extends AbstractAstVisitorRule {
+class EC5003 extends AbstractAstVisitorRule {
 
-    String name = 'DisableObfuscation'
+    String name = 'EC5003'
     int priority = 2
-    Class astVisitorClass = DisableObfuscationAstVisitor
+    Class astVisitorClass = EC5003AstVisitor
 }
 
-class DisableObfuscationAstVisitor extends AbstractAstVisitor {
+class EC5003AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {
diff --git a/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/ruleset/XmlReaderRuleSet.groovy b/codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/ruleset/XmlReaderRuleSet.groovy
@@ -37,6 +37,10 @@ class XmlReaderRuleSet implements RuleSet {
 
     private static final Namespace NS = new Namespace('http://codenarc.org/ruleset/1.0')
     private static final String RULESET_SCHEMA_FILE = 'ruleset-schema.xsd'
+
+    private static final String ECOCODE_RULE_PREFIX = "EC";
+    private static final String ECOCODE_RULE_PACKAGE = "org.codenarc.rule.ecocode."
+
     private final List rules = []
 
     /**
@@ -99,6 +103,10 @@ class XmlReaderRuleSet implements RuleSet {
     private void loadRuleElements(Node ruleset) {
         ruleset[NS.rule].each { ruleNode ->
             def ruleClassName = ruleNode.attribute('class')
+            if (ruleClassName.startsWith(ECOCODE_RULE_PREFIX)) {
+                // ecoCode rules does not have their package in the "class" entry
+                ruleClassName =  ECOCODE_RULE_PACKAGE + ruleClassName.toString()
+            }
             def ruleClass = getClass().classLoader.loadClass(ruleClassName.toString())
             RuleSetUtil.assertClassImplementsRuleInterface(ruleClass)
             def rule = ruleClass.newInstance()
diff --git a/codenarc-converter/CodeNarc/src/main/resources/codenarc-base-messages.properties b/codenarc-converter/CodeNarc/src/main/resources/codenarc-base-messages.properties
@@ -1,11 +1,12 @@
-DisableObfuscation.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
-DisableObfuscation.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 
-SupportedVersionRange.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
-SupportedVersionRange.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
+EC5003.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
+EC5003.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 
-FatApp.description=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
-FatApp.description.html=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
+EC5002.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
+EC5002.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
+
+EC5001.description=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
+EC5001.description.html=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
 
 ParameterAssignmentInFilterClosure.description=An assignment operator was used on a parameter in a filtering closure. This is usually a typo, and the comparison operator (==) was intended.
 ParameterAssignmentInFilterClosure.description.html=An assignment operator was used on a parameter in a filtering closure. This is usually a typo, and the comparison operator (==) was intended.
diff --git a/codenarc-converter/CodeNarc/src/main/resources/codenarc-base-rules.properties b/codenarc-converter/CodeNarc/src/main/resources/codenarc-base-rules.properties
@@ -69,7 +69,6 @@ CoupledTestCase = org.codenarc.rule.junit.CoupledTestCaseRule
 CrapMetric = org.codenarc.rule.size.CrapMetricRule
 CyclomaticComplexity = org.codenarc.rule.size.CyclomaticComplexityRule
 DeadCode = org.codenarc.rule.basic.DeadCodeRule
-DisableObfuscation = org.codenarc.rule.ecocode.DisableObfuscationRule
 DirectConnectionManagement = org.codenarc.rule.jdbc.DirectConnectionManagementRule
 DoubleCheckedLocking = org.codenarc.rule.concurrency.DoubleCheckedLockingRule
 DoubleNegative = org.codenarc.rule.basic.DoubleNegativeRule
@@ -81,6 +80,9 @@ DuplicateMapLiteral = org.codenarc.rule.dry.DuplicateMapLiteralRule
 DuplicateNumberLiteral = org.codenarc.rule.dry.DuplicateNumberLiteralRule
 DuplicateSetValue = org.codenarc.rule.basic.DuplicateSetValueRule
 DuplicateStringLiteral = org.codenarc.rule.dry.DuplicateStringLiteralRule
+EC5001 = org.codenarc.rule.ecocode.EC5001
+EC5002 = org.codenarc.rule.ecocode.EC5002
+EC5003 = org.codenarc.rule.ecocode.EC5003
 ElseBlockBraces = org.codenarc.rule.braces.ElseBlockBracesRule
 EmptyCatchBlock = org.codenarc.rule.basic.EmptyCatchBlockRule
 EmptyClass = org.codenarc.rule.basic.EmptyClassRule
@@ -126,7 +128,6 @@ ExplicitLinkedListInstantiation = org.codenarc.rule.groovyism.ExplicitLinkedList
 ExplicitStackInstantiation = org.codenarc.rule.groovyism.ExplicitStackInstantiationRule
 ExplicitTreeSetInstantiation = org.codenarc.rule.groovyism.ExplicitTreeSetInstantiationRule
 FactoryMethodName = org.codenarc.rule.naming.FactoryMethodNameRule
-FatApp = org.codenarc.rule.ecocode.FatAppRule
 FieldName = org.codenarc.rule.naming.FieldNameRule
 FieldTypeRequired = org.codenarc.rule.convention.FieldTypeRequiredRule
 FileCreateTempFile = org.codenarc.rule.security.FileCreateTempFileRule
@@ -297,7 +298,6 @@ StaticFieldsBeforeInstanceFields = org.codenarc.rule.convention.StaticFieldsBefo
 StaticMatcherField = org.codenarc.rule.concurrency.StaticMatcherFieldRule
 StaticMethodsBeforeInstanceMethods = org.codenarc.rule.convention.StaticMethodsBeforeInstanceMethodsRule
 StaticSimpleDateFormatField = org.codenarc.rule.concurrency.StaticSimpleDateFormatFieldRule
-SupportedVersionRange = org.codenarc.rule.ecocode.SupportedVersionRangeRule
 SwallowThreadDeath = org.codenarc.rule.exceptions.SwallowThreadDeathRule
 SynchronizedMethod = org.codenarc.rule.concurrency.SynchronizedMethodRule
 SynchronizedOnBoxedPrimitive = org.codenarc.rule.concurrency.SynchronizedOnBoxedPrimitiveRule
diff --git a/codenarc-converter/CodeNarc/src/main/resources/codenarc-version.txt b/codenarc-converter/CodeNarc/src/main/resources/codenarc-version.txt
@@ -1 +1 @@
-2.2.3
+2.2.4
diff --git a/codenarc-converter/CodeNarc/src/main/resources/rulesets/ecocode.xml b/codenarc-converter/CodeNarc/src/main/resources/rulesets/ecocode.xml
@@ -7,7 +7,7 @@
         EcoCode rule set.
     </description>
 
-    <rule class='org.codenarc.rule.ecocode.FatAppRule'/>
-    <rule class='org.codenarc.rule.ecocode.SupportedVersionRangeRule'/>
-    <rule class='org.codenarc.rule.ecocode.DisableObfuscationRule'/>
+    <rule class='org.codenarc.rule.ecocode.EC5001'/>
+    <rule class='org.codenarc.rule.ecocode.EC5002'/>
+    <rule class='org.codenarc.rule.ecocode.EC5003'/>
 </ruleset>
diff --git a/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5001Test.groovy b/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5001Test.groovy
diff --git a/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5002Test.groovy b/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5002Test.groovy
diff --git a/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5003Test.groovy b/codenarc-converter/CodeNarc/src/test/groovy/org/codenarc/rule/ecocode/EC5003Test.groovy
diff --git a/codenarc-converter/pom.xml b/codenarc-converter/pom.xml
diff --git a/codenarc-converter/src/main/java/org/sonar/plugins/groovy/codenarc/parser/markdown/RuleSetVisitor.java b/codenarc-converter/src/main/java/org/sonar/plugins/groovy/codenarc/parser/markdown/RuleSetVisitor.java
diff --git a/tool_prepare-codenarc.bat b/tool_prepare-codenarc.bat
diff --git a/tool_prepare-codenarc.sh b/tool_prepare-codenarc.sh
