Make the groovy rule key to ecoCode standard for EC5001 and improve CodeNarc to understand it

Author: jhertout

android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv

@@ -1,4 +1,4 @@
 ruleKey;remediationFunction;remediationFactor
-org.codenarc.rule.ecocode.EC5001;linear;1h
+EC5001;linear;1h
 org.codenarc.rule.ecocode.SupportedVersionRangeRule;linear;10min
 org.codenarc.rule.ecocode.DisableObfuscationRule;linear;10min

android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt

@@ -1,3 +1,3 @@
-org.codenarc.rule.ecocode.EC5001
+EC5001
 org.codenarc.rule.ecocode.SupportedVersionRangeRule
 org.codenarc.rule.ecocode.DisableObfuscationRule

android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml

@@ -4,7 +4,7 @@
 
   <!-- since 2.2.1 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.EC5001</key>
+    <key>EC5001</key>
     <severity>MINOR</severity>
     <name><![CDATA[Fat App]]></name>
     <internalKey><![CDATA[EC5001]]></internalKey>

codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/ruleset/XmlReaderRuleSet.groovy

@@ -37,6 +37,10 @@ class XmlReaderRuleSet implements RuleSet {
 
     private static final Namespace NS = new Namespace('http://codenarc.org/ruleset/1.0')
     private static final String RULESET_SCHEMA_FILE = 'ruleset-schema.xsd'
+
+    private static final String ECOCODE_RULE_PREFIX = "EC";
+    private static final String ECOCODE_RULE_PACKAGE = "org.codenarc.rule.ecocode."
+
     private final List rules = []
 
     /**
@@ -99,6 +103,10 @@ class XmlReaderRuleSet implements RuleSet {
     private void loadRuleElements(Node ruleset) {
         ruleset[NS.rule].each { ruleNode ->
             def ruleClassName = ruleNode.attribute('class')
+            if (ruleClassName.startsWith(ECOCODE_RULE_PREFIX)) {
+                // ecoCode rules does not have their package in the "class" entry
+                ruleClassName =  ECOCODE_RULE_PACKAGE + ruleClassName.toString()
+            }
             def ruleClass = getClass().classLoader.loadClass(ruleClassName.toString())
             RuleSetUtil.assertClassImplementsRuleInterface(ruleClass)
             def rule = ruleClass.newInstance()