Rename groovy FatApp rule to EC5001

Author: jhertout

android-plugin/src/main/resources/org/sonar/plugins/groovy/cost.csv

@@ -1,4 +1,4 @@
 ruleKey;remediationFunction;remediationFactor
-org.codenarc.rule.ecocode.FatAppRule;linear;1h
+org.codenarc.rule.ecocode.EC5001Rule;linear;1h
 org.codenarc.rule.ecocode.SupportedVersionRangeRule;linear;10min
 org.codenarc.rule.ecocode.DisableObfuscationRule;linear;10min

android-plugin/src/main/resources/org/sonar/plugins/groovy/profile-default.txt

@@ -1,3 +1,3 @@
-org.codenarc.rule.ecocode.FatAppRule
+org.codenarc.rule.ecocode.EC5001Rule
 org.codenarc.rule.ecocode.SupportedVersionRangeRule
 org.codenarc.rule.ecocode.DisableObfuscationRule

android-plugin/src/main/resources/org/sonar/plugins/groovy/rules.xml

@@ -4,10 +4,10 @@
 
   <!-- since 2.2.1 -->
   <rule>
-    <key>org.codenarc.rule.ecocode.FatAppRule</key>
+    <key>org.codenarc.rule.ecocode.EC5001Rule</key>
     <severity>MINOR</severity>
     <name><![CDATA[Fat App]]></name>
-    <internalKey><![CDATA[FatApp]]></internalKey>
+    <internalKey><![CDATA[EC5001]]></internalKey>
     <description><![CDATA[<p>Using &quot;multiDexEnabled true&quot; goes against the overall reduction of the weight of the apps and hence must be avoided.</p>
 <p>Example of violations:</p>
 <pre><code>    android {

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRules.groovy.txt

@@ -88,6 +88,7 @@ ruleset {
     DuplicateNumberLiteral 
     DuplicateSetValue 
     DuplicateStringLiteral 
+    EC5001
     ElseBlockBraces 
     EmptyCatchBlock 
     EmptyClass
@@ -133,7 +134,6 @@ ruleset {
     ExplicitStackInstantiation
     ExplicitTreeSetInstantiation
     FactoryMethodName
-    FatApp
     FieldName 
     FieldTypeRequired 
     FileCreateTempFile 

codenarc-converter/CodeNarc/docs/StarterRuleSet-AllRulesByCategory.groovy.txt

@@ -166,7 +166,7 @@ ruleset {
     DuplicateStringLiteral
 
     // rulesets/ecocode.xml
-    FatApp
+    EC5001
     SupportedVersionRange
     DisableObfuscation
 

codenarc-converter/CodeNarc/docs/codenarc-rule-index-by-name.md

@@ -90,6 +90,7 @@ title: CodeNarc - Rule Index by Name
 * [DuplicateNumberLiteral](./codenarc-rules-dry.html#duplicatenumberliteral-rule)
 * [DuplicateSetValue](./codenarc-rules-basic.html#duplicatesetvalue-rule)
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
+* [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
 * [ElseBlockBraces](./codenarc-rules-braces.html#elseblockbraces-rule)
 * [EmptyCatchBlock](./codenarc-rules-basic.html#emptycatchblock-rule)
 * [EmptyClass](./codenarc-rules-basic.html#emptyclass-rule)
@@ -135,7 +136,6 @@ title: CodeNarc - Rule Index by Name
 * [ExplicitStackInstantiation](./codenarc-rules-groovyism.html#explicitstackinstantiation-rule)
 * [ExplicitTreeSetInstantiation](./codenarc-rules-groovyism.html#explicittreesetinstantiation-rule)
 * [FactoryMethodName](./codenarc-rules-naming.html#factorymethodname-rule)
-* [FatApp](./codenarc-rules-ecocode.html#fatapp-rule)
 * [FieldName](./codenarc-rules-naming.html#fieldname-rule)
 * [FieldTypeRequired](./codenarc-rules-convention.html#fieldtyperequired-rule)
 * [FileCreateTempFile](./codenarc-rules-security.html#filecreatetempfile-rule)

codenarc-converter/CodeNarc/docs/codenarc-rule-index.md

@@ -167,7 +167,7 @@ title: CodeNarc - Rule Index
 * [DuplicateStringLiteral](./codenarc-rules-dry.html#duplicatestringliteral-rule)
 
 ## [Ecocode](./codenarc-rules-ecocode.html)
-* [FatApp](./codenarc-rules-ecocode.html#fatapp-rule)
+* [EC5001](./codenarc-rules-ecocode.html#EC5001-rule)
 * [SupportedVersionRange](./codenarc-rules-ecocode.html#supportedversionrange-rule)
 * [DisableObfuscation](./codenarc-rules-ecocode.html#disableobfuscation-rule)
 

codenarc-converter/CodeNarc/docs/codenarc-rules-ecocode.md

@@ -5,7 +5,7 @@ title: CodeNarc - Ecocode Rules
 
 # Ecocode Rules  ("*rulesets/ecocode.xml*")
 
-## FatApp Rule
+## EC5001 Rule
 
 *Since CodeNarc 2.2.1*
 
@@ -119,4 +119,3 @@ Example of violations:
         }
     }
 ```
-

codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/FatAppRule.groovy renamed to codenarc-converter/CodeNarc/src/main/groovy/org/codenarc/rule/ecocode/EC5001Rule.groovy

@@ -29,14 +29,14 @@ import org.codenarc.util.AstUtil
  *
  * @author Leboulanger Mickael
  */
-class FatAppRule extends AbstractAstVisitorRule {
+class EC5001Rule extends AbstractAstVisitorRule {
 
-    String name = 'FatApp'
+    String name = 'EC5001'
     int priority = 2
-    Class astVisitorClass = FatAppAstVisitor
+    Class astVisitorClass = EC5001AstVisitor
 }
 
-class FatAppAstVisitor extends AbstractAstVisitor {
+class EC5001AstVisitor extends AbstractAstVisitor {
 
     @Override
     void visitMethodCallExpression(MethodCallExpression methodCallExpression) {

codenarc-converter/CodeNarc/src/main/resources/codenarc-base-messages.properties

@@ -1,11 +1,12 @@
+
 DisableObfuscation.description=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 DisableObfuscation.description.html=Using minifyEnabled true will obfuscate code and will have a sligthly negative impact on power consumption at runtime.
 
 SupportedVersionRange.description=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
 SupportedVersionRange.description.html=The amplitude of supported platform versions should not be too wide, at the risk of making the app too heavy to handle all cases.
 
-FatApp.description=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
-FatApp.description.html=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
+EC5001.description=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
+EC5001.description.html=Using "multiDexEnabled true" goes against the overall reduction of the weight of the apps and hence must be avoided.
 
 ParameterAssignmentInFilterClosure.description=An assignment operator was used on a parameter in a filtering closure. This is usually a typo, and the comparison operator (==) was intended.
 ParameterAssignmentInFilterClosure.description.html=An assignment operator was used on a parameter in a filtering closure. This is usually a typo, and the comparison operator (==) was intended.