refactor: Changes rule keys for XML rules to prefix each one by EC

Modifications:
* Change android/xml rule key: EBAT001 -> EC540
* Change android/xml rule key: EIDL003 -> EC541
* Change android/xml rule key: EIDL005 -> EC542
* Change android/xml rule key: EPOW002 -> EC543
* Change android/xml rule key: EPOW003 -> EC544
* Change android/xml rule key: EPOW005 -> EC545
* Change android/xml rule key: EPOW007 -> EC546
* Change android/xml rule key: ESOB003 -> EC547
* Change android/xml rule key: ESOB004 -> EC548

Author: jycr

android-plugin/src/main/java/io/ecocode/xml/Xml.java

@@ -20,10 +20,10 @@
 package io.ecocode.xml;
 
 public interface Xml { //NOSONAR - we use the interface for constant without inheriting it
-    String REPOSITORY_NAME = "ecoCode";
+    String REPOSITORY_NAME = "ecoCode (Android)";
     String PROFILE_NAME = "ecoCode";
     String KEY = "xml";
-    String REPOSITORY_KEY = "ecoCode-xml";
-    String XML_RESOURCE_PATH = "io/ecocode/xml/rules";
+    String REPOSITORY_KEY = "ecocode-android-xml";
+    String RULES_SPECIFICATIONS_XML_PATH = "io/ecocode/rules/xml";
     String PROFILE_PATH = "io/ecocode/xml/rules/ecocode_xml_profile.json";
 }

android-plugin/src/main/java/io/ecocode/xml/XmlRulesDefinition.java

@@ -33,7 +33,7 @@ public final class XmlRulesDefinition implements RulesDefinition {
     public void define(Context context) {
         NewRepository repository = context.createRepository(Xml.REPOSITORY_KEY, Xml.KEY).setName(Xml.REPOSITORY_NAME);
         SonarRuntime sonarRuntime = SonarRuntimeImpl.forSonarQube(Version.create(9, 8), SonarQubeSide.SCANNER, SonarEdition.DEVELOPER);
-        RuleMetadataLoader ruleMetadataLoader = new RuleMetadataLoader(Xml.XML_RESOURCE_PATH, Xml.PROFILE_PATH,sonarRuntime);
+        RuleMetadataLoader ruleMetadataLoader = new RuleMetadataLoader(Xml.RULES_SPECIFICATIONS_XML_PATH, Xml.PROFILE_PATH,sonarRuntime);
 
         // add the new checks
         ruleMetadataLoader.addRulesByAnnotatedClass(repository, XmlCheckList.getXmlChecks());

android-plugin/src/main/java/io/ecocode/xml/checks/batch/ServiceBootTimeXmlRule.java

@@ -21,11 +21,13 @@
 
 import io.ecocode.xml.checks.XPathSimpleCheck;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest intent-filter statement: if the action is BOOT_COMPLETED, report a bad practice
  */
-@Rule(key = "EBAT001", name = "ecoServiceBootTimeXml")
+@Rule(key = "EC540")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EBAT001")
 public class ServiceBootTimeXmlRule extends XPathSimpleCheck {
 
     private static final String SERVICE_BOOT_TIME_ATTRIBUTE = "//manifest/application/receiver/intent-filter/action/@name[. = \"android.intent.action.BOOT_COMPLETED\"]";

android-plugin/src/main/java/io/ecocode/xml/checks/idleness/KeepCpuOnXmlRule.java

@@ -21,12 +21,14 @@
 
 import io.ecocode.xml.checks.helpers.CheckPermissionsRule;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest uses-permissions statement.
  * if the permissions "android.permission.WAKE_LOCK" is found, report an issue.
  */
-@Rule(key = "EIDL005", name = "ecocodeKeepCpuOnXml")
+@Rule(key = "EC542")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EIDL005")
 public class KeepCpuOnXmlRule extends CheckPermissionsRule {
 
     private static final String PERMISSION_NAME = "android.permission.WAKE_LOCK";
@@ -35,4 +37,4 @@ public class KeepCpuOnXmlRule extends CheckPermissionsRule {
     public KeepCpuOnXmlRule() {
         super(PERMISSION_NAME, ERROR_MESSAGE);
     }
-}
+}

android-plugin/src/main/java/io/ecocode/xml/checks/idleness/KeepScreenOnXmlRule.java

@@ -21,8 +21,10 @@
 
 import io.ecocode.xml.checks.XPathSimpleCheck;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
-@Rule(key = "EIDL003", name = "ecoKeepScreenOnXml")
+@Rule(key = "EC541")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EIDL003")
 public class KeepScreenOnXmlRule extends XPathSimpleCheck {
 
     private static final String KEEP_SCREEN_ON_XML_ATTRIBUTE = "//*[contains(@keepScreenOn, 'true')]/@keepScreenOn";

android-plugin/src/main/java/io/ecocode/xml/checks/power/ChargeAwarenessXmlRule.java

@@ -21,12 +21,14 @@
 
 import io.ecocode.xml.checks.XPathSimpleCheck;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest intent-filter statement: if the action is ACTION_POWER_CONNECTED, ACTION_POWER_DISCONNECTED,
  * BATTERY_OKAY or BATTERY_LOW report a good practice.
  */
-@Rule(key = "EPOW005", name = "ecocodeBatteryAwarenessXml")
+@Rule(key = "EC545")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EPOW005")
 public class ChargeAwarenessXmlRule extends XPathSimpleCheck {
 
     private String xPathActionPowerConnected = "//manifest/application/receiver/intent-filter/action/@name[.=\"android.intent.action.ACTION_POWER_CONNECTED\"]";

android-plugin/src/main/java/io/ecocode/xml/checks/power/CompagnionInBackgroundXmlRule.java

@@ -21,12 +21,14 @@
 
 import io.ecocode.xml.checks.helpers.CheckPermissionsRule;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest uses-permissions statement:
  * if the permission "android.permission.REQUEST_COMPANION_RUN_IN_BACKGROUND" is found, report an issue.
  */
-@Rule(key = "EPOW002", name = "ecocodeCompagnionInBackgroundXml")
+@Rule(key = "EC543")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EPOW002")
 public class CompagnionInBackgroundXmlRule extends CheckPermissionsRule {
 
     private static final String PERMISSION_NAME = "android.permission.REQUEST_COMPANION_RUN_IN_BACKGROUND";

android-plugin/src/main/java/io/ecocode/xml/checks/power/IgnoreBatteryOptimizationsXmlRule.java

@@ -21,12 +21,14 @@
 
 import io.ecocode.xml.checks.helpers.CheckPermissionsRule;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest uses-permissions statement:
  * if the permission "android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" is found, report an issue.
  */
-@Rule(key = "EPOW003", name = "ecocodeIgnoreBatteryOptimizations")
+@Rule(key = "EC544")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EPOW003")
 public class IgnoreBatteryOptimizationsXmlRule extends CheckPermissionsRule {
 
     private static final String PERMISSION_NAME = "android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS";

android-plugin/src/main/java/io/ecocode/xml/checks/power/SaveModeAwarenessXmlRule.java

@@ -21,12 +21,14 @@
 
 import io.ecocode.xml.checks.XPathSimpleCheck;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 
 /**
  * Checks manifest uses-permissions statement:
  * if the permission "android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS" is found, report an issue.
  */
-@Rule(key = "EPOW007", name = "ecocodeSaveModeAwarenessXml")
+@Rule(key = "EC546")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "EPOW007")
 public class SaveModeAwarenessXmlRule extends XPathSimpleCheck {
 
     private static final String ACTION_POWER_CHANGED_XPATH = "//manifest/application/receiver/intent-filter/action/@name[.=\"android.intent.action.BATTERY_CHANGED\"]";
@@ -41,4 +43,4 @@ protected String getMessage() {
     protected String getXPathExpressionString() {
         return ACTION_POWER_CHANGED_XPATH;
     }
-}
+}

android-plugin/src/main/java/io/ecocode/xml/checks/sobriety/DarkUIBrightColorsXmlRule.java

@@ -21,6 +21,7 @@
 
 import io.ecocode.xml.checks.XPathCheck;
 import org.sonar.check.Rule;
+import org.sonarsource.analyzer.commons.annotations.DeprecatedRuleKey;
 import org.w3c.dom.Node;
 
 /**
@@ -36,7 +37,8 @@
  *      <li>If the value is an hexa value >= to a given brightness threshold throw an issue</li>
  *  </ul>
  */
-@Rule(key = "ESOB003", name = "ecocodeCheckColorXml")
+@Rule(key = "EC547")
+@DeprecatedRuleKey(repositoryKey = "ecoCode-xml", ruleKey = "ESOB003")
 public class DarkUIBrightColorsXmlRule extends XPathCheck {
 
     private static final String[] ATTRIBUTES_TO_CHECK = {