Skip to content

Commit 270463c

Browse files
committed
Fxing the network provider stderror
1 parent b20d32a commit 270463c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

runner.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -832,7 +832,7 @@ def setup_services(self):
832832
if 'cmd' in service: # must come last
833833
docker_run_string.append(service['cmd'])
834834

835-
# Before starting the container, check if the dependent containers are "ready".
835+
# Before starting the container, check if the dependent containers are "ready".
836836
# If not, wait for some time. If the container is not ready after a certain time, throw an error.
837837
# Currently we consider "ready" only as "running".
838838
# In the future we want to implement an health check to know if dependent containers are actually ready.
@@ -961,7 +961,7 @@ def start_metric_providers(self, allow_container=True, allow_other=True):
961961

962962
stderr_read = metric_provider.get_stderr()
963963
print(f"Stderr check on {metric_provider.__class__.__name__}")
964-
if stderr_read is not None:
964+
if stderr_read is not None and str(stderr_read) is not '':
965965
raise RuntimeError(f"Stderr on {metric_provider.__class__.__name__} was NOT empty: {stderr_read}")
966966

967967

@@ -1095,7 +1095,7 @@ def stop_metric_providers(self):
10951095
continue
10961096

10971097
stderr_read = metric_provider.get_stderr()
1098-
if stderr_read is not None:
1098+
if stderr_read is not None and str(stderr_read) is not '':
10991099
errors.append(f"Stderr on {metric_provider.__class__.__name__} was NOT empty: {stderr_read}")
11001100

11011101
metric_provider.stop_profiling()

0 commit comments

Comments
 (0)