Skip to content

Commit 6334f0e

Browse files
committed
Toasts are now more visible errors by default if no class given
1 parent b389312 commit 6334f0e

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

frontend/js/helpers/main.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ const replaceRepoIcon = (uri) => {
182182
return `<i class="icon ${iconClass}"></i>` + uri.substring(url.origin.length);
183183
};
184184

185-
const showNotification = (message_title, message_text, type='warning') => {
185+
const showNotification = (message_title, message_text, type='error') => {
186186
if (typeof message_text === 'object') console.log(message_text); // this is most likey an error. We need it in the console
187187

188188
const message = (typeof message_text === 'string' || typeof message_text === 'object') ? message_text : JSON.stringify(message_text);
@@ -194,9 +194,6 @@ const showNotification = (message_title, message_text, type='warning') => {
194194
displayTime: 5000,
195195
title: message_title,
196196
message: message,
197-
className: {
198-
toast: 'ui message'
199-
}
200197
});
201198
return;
202199
}

frontend/js/settings.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ const updateSetting = async (el) => {
55
if (left_el.type == 'select-multiple') {
66
const value = $(left_el).dropdown('get values');
77
await makeAPICall('/v1/user/setting', {name: name, value: value}, null, true)
8-
showNotification('Save success!', `${name} = ${value}`)
8+
showNotification('Save success!', `${name} = ${value}`, 'success')
99
} else if (left_el.type == 'checkbox') {
1010
await makeAPICall('/v1/user/setting', {name: name, value: left_el.checked}, null, true)
11-
showNotification('Save success!', `${name} = ${left_el.checked}`)
11+
showNotification('Save success!', `${name} = ${left_el.checked}`, 'success')
1212
} else {
1313
await makeAPICall('/v1/user/setting', {name: name, value: left_el.value}, null, true)
14-
showNotification('Save success!', `${name} = ${left_el.value}`)
14+
showNotification('Save success!', `${name} = ${left_el.value}`, 'success')
1515
}
1616
} catch (err) {
1717
showNotification('Could not save setting', err);

0 commit comments

Comments
 (0)