Skip to content

Commit b7c19fb

Browse files
committed
Clarifying comment for design decision
1 parent 33993f2 commit b7c19fb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docker/structure.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ CREATE TABLE measurement_metrics (
280280
sampling_rate_configured int NOT NULL
281281
);
282282

283-
CREATE UNIQUE INDEX measurement_metrics_get ON measurement_metrics(run_id,metric,detail_name); -- technically we could allow also different units, but we want to see the use case for that first
283+
CREATE UNIQUE INDEX measurement_metrics_get ON measurement_metrics(run_id,metric,detail_name); -- technically we could allow also different units, but we want to see the use case for that first. Also a lot of code relies on detail_name to be the final discriminator (e.g. metric providers .transform(utils.df_fill_mean) etc.m which then need to be rewritten)
284284
CREATE INDEX measurement_metrics_build_and_store_phase_stats ON measurement_metrics(run_id,metric,detail_name,unit);
285285
CREATE INDEX measurement_metrics_build_phases ON measurement_metrics(metric,detail_name,unit);
286286

0 commit comments

Comments
 (0)