-
Notifications
You must be signed in to change notification settings - Fork 34
Micro phases #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArneTR
wants to merge
10
commits into
main
Choose a base branch
from
micro-phases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Micro phases #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout of None will lead to no timeout
…ng routine of runner private attributes; Small Bugfixes
* main: Bump actions/create-github-app-token in /.github/workflows (#1284) Bump pylint from 3.3.7 to 3.3.8 (#1285) Updated echarts vor v.6.0 (#1282) Bump python from 3.13.5-slim-bookworm to 3.13.6-slim-bookworm in /docker (#1286) Bump deepdiff from 8.5.0 to 8.6.0 (#1283) Log parsing on full data (#1276) Bump redis from 6.3.0 to 6.4.0 (#1281) Added Gemini PR Review measurement_flow_process_duration is set in any case. Supplying a timeout of None will lead to no timeout Detect systemd cgroup path using cgroup name (instead of container id) (#1270) Bump redis from 6.2.0 to 6.3.0 (#1275)
* main: Bump requests from 2.32.4 to 2.32.5 (#1298) Fix output of container logs ("print-logs" flag) + Reuse ScenarioRunner object for all files/iterations (#1290) Bump actions/checkout from 4 to 5 in /.github/workflows (#1295) Bump python from 3.13.6-slim-bookworm to 3.13.7-slim-bookworm in /docker (#1293) Bump actions/create-github-app-token in /.github/workflows (#1294) Updated Gemini Actions Workflow to latest version from upstream Update gemini-pr-review.yml - Only run when actively triggered via comment Bump orjson from 3.11.1 to 3.11.2 (#1288)
This PR was also used to evaluate integrating GitHub Actions into GMT. The corresponding repo describing why we believe this is currently only possible with a very high effort integration is at : https://github.com/green-coding-solutions/eco-ci-runner-inside-gmt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Micro Phases are a concept in GMT to dynamically create phases from stdout of running processes.
Example: You have such a usage scenario:
The Playwright browser might run multiple tests but in GMT they would only show up as one phase.
However by reading and parsing the stdout alongside timestamps set there GMT can now expand them to separate phases.
This works by using a regex on the stdout and capturing three groups:
A working stdout can for instance look something like this:
The flow would then updated with a regex like so:
The implementation atm requires strong regex knowledge and, if not already present, instrumentation of the stdout to contain the needed timestamps and event names that shall be used as phase names.
Example of how phase names are then later expanded
Open Problems