Merge pull request #335 from greenbone/fix/gsad-chroot-working-directory

fix: chdir("/") after chroot to fix static path resolution

Author: bjoernricks

src/gsad.c

@@ -1264,7 +1264,7 @@ drop_privileges (struct passwd *user_pw)
 static int
 chroot_drop_privileges (gboolean do_chroot, const gchar *drop, const gchar *dir)
 {
-  struct passwd *user_pw;
+  struct passwd *user_pw = NULL;
 
   if (drop)
     {
@@ -1277,8 +1277,6 @@ chroot_drop_privileges (gboolean do_chroot, const gchar *drop, const gchar *dir)
           return 1;
         }
     }
-  else
-    user_pw = NULL;
 
   if (do_chroot)
     {
@@ -1290,28 +1288,34 @@ chroot_drop_privileges (gboolean do_chroot, const gchar *drop, const gchar *dir)
           return 1;
         }
       set_chroot_state (1);
+
+      if (chdir ("/"))
+        {
+          g_critical ("failed to change to \"/\" after chroot: %s",
+                      strerror (errno));
+          return 1;
+        }
+
       g_info ("Chrooted to \"%s\"", dir);
     }
-
-  if (user_pw)
+  else
     {
-      if (drop_privileges (user_pw) == FALSE)
+      if (chdir (dir))
         {
-          g_critical ("Failed to drop privileges");
+          g_critical ("failed to change to \"%s\": %s", dir, strerror (errno));
           return 1;
         }
-      else
-        g_info ("Dropped privileges to user \"%s\" (uid: %d, gid: %d)", drop,
-                user_pw->pw_uid, user_pw->pw_gid);
+      g_info ("Serving from directory %s", dir);
     }
 
-  if (!do_chroot)
+  if (user_pw)
     {
-      if (chdir (dir))
+      if (drop_privileges (user_pw) == FALSE)
         {
-          g_critical ("failed to change to \"%s\": %s", dir, strerror (errno));
+          g_critical ("Failed to drop privileges");
           return 1;
         }
+
       g_debug ("Working directory is %s", dir);
     }