Change: move first target functions to dedicated files

Author: mattmundell

src/CMakeLists.txt

@@ -197,6 +197,7 @@ set(
   manage_scan_queue.c
   manage_oci_image_targets.c
   manage_container_image_scanner.c
+  manage_targets.c
   manage_users.c
 )
 
@@ -231,6 +232,7 @@ set(
   manage_sql_report_formats.c
   manage_sql_resources.c
   manage_sql_roles.c
+  manage_sql_targets.c
   manage_sql_tickets.c
   manage_sql_tls_certificates.c
   manage_sql_users.c
@@ -722,6 +724,7 @@ set(
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_resources.c"
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_roles.c"
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_secinfo.c"
+  "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_targets.c"
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_tickets.c"
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_tls_certificates.c"
   "${CMAKE_CURRENT_SOURCE_DIR}/manage_sql_users.c"

src/gmp.c

@@ -106,6 +106,7 @@
 #include "manage_resources.h"
 #include "manage_roles.h"
 #include "manage_runtime_flags.h"
+#include "manage_targets.h"
 #include "manage_tls_certificates.h"
 #include "manage_users.h"
 #include "sql.h"

src/manage.h

@@ -1621,9 +1621,6 @@ prognosis_iterator_description (iterator_t*);
  */
 #define MANAGE_USER_MAX_HOSTS 16777216
 
-int
-manage_max_hosts ();
-
 int
 manage_count_hosts (const char *, const char *);
 

src/manage_sql.c

@@ -53,6 +53,7 @@
 #include "manage_sql_report_formats.h"
 #include "manage_sql_resources.h"
 #include "manage_sql_roles.h"
+#include "manage_sql_targets.h"
 #include "manage_sql_tickets.h"
 #include "manage_sql_tls_certificates.h"
 #include "manage_sql_users.h"
@@ -286,11 +287,6 @@ type_build_select (const char *, const char *, const get_data_t *,
  */
 manage_connection_forker_t manage_fork_connection;
 
-/**
- * @brief Max number of hosts per target.
- */
-static int max_hosts = MANAGE_MAX_HOSTS;
-
 /**
  * @brief Memory cache of NVT information from the database.
  */
@@ -4632,7 +4628,7 @@ init_manage_internal (GSList *log_config,
       || (max_ips_per_target > MANAGE_ABSOLUTE_MAX_IPS_PER_TARGET))
     return -4;
 
-  max_hosts = max_ips_per_target;
+  manage_set_max_hosts (max_ips_per_target);
   if (max_email_attachment_size)
     set_max_email_attachment_size (max_email_attachment_size);
   if (max_email_include_size)
@@ -4684,7 +4680,7 @@ init_manage_internal (GSList *log_config,
       sql ("INSERT INTO meta (name, value)"
            " VALUES ('max_hosts', %i)"
            " ON CONFLICT (name) DO UPDATE SET value = EXCLUDED.value;",
-           max_hosts);
+           manage_max_hosts ());
     }
 
   if (stop_tasks)
@@ -20382,28 +20378,6 @@ modify_task (const gchar *task_id, const gchar *name,
 
 /* Targets. */
 
-/**
- * @brief Get the maximum allowed number of hosts per target.
- *
- * @return Maximum.
- */
-int
-manage_max_hosts ()
-{
-  return max_hosts;
-}
-
-/**
- * @brief Set the maximum allowed number of hosts per target.
- *
- * @param[in]   new_max   New max_hosts value.
- */
-void
-manage_set_max_hosts (int new_max)
-{
-  max_hosts = new_max;
-}
-
 /**
  * @brief Find a target for a specific permission, given a UUID.
  *
@@ -21050,7 +21024,7 @@ create_target (const char* name, const char* asset_hosts_filter,
       sql_rollback ();
       return 2;
     }
-  if (max > max_hosts)
+  if (max > manage_max_hosts ())
     {
       g_free (clean);
       g_free (clean_exclude);
@@ -21977,7 +21951,7 @@ modify_target (const char *target_id, const char *name, const char *hosts,
           return 2;
         }
 
-      if (max > max_hosts)
+      if (max > manage_max_hosts ())
         {
           g_free (clean);
           g_free (clean_exclude);

src/manage_sql.h

@@ -596,9 +596,6 @@ ldap_auth_enabled ();
 int
 radius_auth_enabled ();
 
-void
-manage_set_max_hosts (int);
-
 gchar*
 clean_hosts (const char *, int *);
 

src/manage_sql_targets.c

@@ -0,0 +1,14 @@
+/* Copyright (C) 2026 Greenbone AG
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+#include "manage_sql_targets.h"
+
+/**
+ * @file
+ * @brief GVM management layer: Targets SQL
+ *
+ * The Targets SQL for the GVM management layer.
+ */
+

src/manage_sql_targets.h

@@ -0,0 +1,11 @@
+/* Copyright (C) 2026 Greenbone AG
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+#ifndef _GVMD_MANAGE_SQL_TARGETS_H
+#define _GVMD_MANAGE_SQL_TARGETS_H
+
+#include "manage_targets.h"
+
+#endif // not _GVMD_MANAGE_SQL_TARGETS_H

src/manage_sql_users.c

@@ -16,6 +16,7 @@
 #include "manage_sql_report_formats.h"
 #include "manage_sql_resources.h"
 #include "manage_sql_roles.h"
+#include "manage_sql_targets.h"
 #include "manage_sql_tickets.h"
 #include "manage_sql_tls_certificates.h"
 #include "sql.h"

src/manage_targets.c

@@ -0,0 +1,40 @@
+/* Copyright (C) 2026 Greenbone AG
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+#include "manage_sql_targets.h"
+#include "manage.h"
+
+#undef G_LOG_DOMAIN
+/**
+ * @brief GLib log domain.
+ */
+#define G_LOG_DOMAIN "md manage"
+
+/**
+ * @brief Max number of hosts per target.
+ */
+static int max_hosts = MANAGE_MAX_HOSTS;
+
+/**
+ * @brief Get the maximum allowed number of hosts per target.
+ *
+ * @return Maximum.
+ */
+int
+manage_max_hosts ()
+{
+  return max_hosts;
+}
+
+/**
+ * @brief Set the maximum allowed number of hosts per target.
+ *
+ * @param[in]   new_max   New max_hosts value.
+ */
+void
+manage_set_max_hosts (int new_max)
+{
+  max_hosts = new_max;
+}

src/manage_targets.h

@@ -0,0 +1,15 @@
+/* Copyright (C) 2026 Greenbone AG
+ *
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+#ifndef _GVMD_MANAGE_TARGETS_H
+#define _GVMD_MANAGE_TARGETS_H
+
+int
+manage_max_hosts ();
+
+void
+manage_set_max_hosts (int);
+
+#endif /* not _GVMD_MANAGE_TARGETS_H */