Fix: insert alive test methods and ports (#2155)

 Methods and ports are not inserted and the default icmp methods is always used

Author: jjnicola

rust/crates/greenbone-scanner-framework/src/models/port.rs

@@ -84,6 +84,15 @@ impl Display for Protocol {
     }
 }
 
+impl AsRef<str> for Protocol {
+    fn as_ref(&self) -> &str {
+        match self {
+            Protocol::TCP => "tcp",
+            Protocol::UDP => "udp",
+        }
+    }
+}
+
 pub fn ports_to_openvas_port_list(ports: Vec<Port>) -> Option<String> {
     fn add_range_to_list(list: &mut String, start: usize, end: Option<usize>) {
         // Add range

rust/crates/greenbone-scanner-framework/src/models/target.rs

@@ -54,6 +54,18 @@ pub enum AliveTestMethodsError {
     InvalidValue(u8),
 }
 
+impl AsRef<str> for AliveTestMethods {
+    fn as_ref(&self) -> &str {
+        match self {
+            AliveTestMethods::TcpAck => "tcp_ack",
+            AliveTestMethods::Icmp => "icmp",
+            AliveTestMethods::Arp => "arp",
+            AliveTestMethods::ConsiderAlive => "consider_alive",
+            AliveTestMethods::TcpSyn => "tcp_syn",
+        }
+    }
+}
+
 impl TryFrom<u8> for AliveTestMethods {
     type Error = AliveTestMethodsError;
 

rust/src/openvasd/database/sqlite/scans.rs

@@ -140,14 +140,13 @@ where
                     port.range
                         .clone()
                         .into_iter()
-                        .map(move |r| (port.protocol, r))
+                        .map(move |r| (port.protocol.as_ref(), r))
                 }),
                 |mut b, (protocol, range)| {
                     b.push_bind(&mapped_id)
                         .push_bind(match protocol {
                             None => "udp_tcp",
-                            Some(models::Protocol::TCP) => "tcp",
-                            Some(models::Protocol::UDP) => "udp",
+                            Some(x) => x.as_ref(),
                         })
                         .push_bind(range.start as i64)
                         .push_bind(range.end.map(|x| x as i64));
@@ -158,6 +157,47 @@ where
             query.execute(&mut *tx).await?;
         }
     }
+    if !scan.target.alive_test_ports.is_empty() {
+        for ports in scan
+            .target
+            .alive_test_ports
+            .chunks(SQLITE_LIMIT_VARIABLE_NUMBER / 4)
+        {
+            let mut builder =
+                QueryBuilder::new("INSERT INTO ports (id, protocol, start, end, alive)");
+            builder.push_values(
+                ports.iter().flat_map(|port| {
+                    port.range
+                        .clone()
+                        .into_iter()
+                        .map(move |r| (port.protocol.as_ref(), r))
+                }),
+                |mut b, (protocol, range)| {
+                    b.push_bind(&mapped_id)
+                        .push_bind(match protocol {
+                            None => "udp_tcp",
+                            Some(x) => x.as_ref(),
+                        })
+                        .push_bind(range.start as i64)
+                        .push_bind(range.end.map(|x| x as i64))
+                        .push_bind(true);
+                },
+            );
+            let query = builder.build();
+
+            query.execute(&mut *tx).await?;
+        }
+    }
+
+    if !scan.target.alive_test_methods.is_empty() {
+        let mut builder = QueryBuilder::new("INSERT INTO alive_methods (id, method)");
+        builder.push_values(&scan.target.alive_test_methods, |mut b, method| {
+            b.push_bind(&mapped_id).push_bind(method.as_ref());
+        });
+        let query = builder.build();
+        query.execute(&mut *tx).await?;
+    }
+
     let mut scan_preferences = scan.scan_preferences.clone();
     if scan.target.reverse_lookup_unify.unwrap_or_default() {
         scan_preferences.push(models::ScanPreference {