Merge pull request #290 from y0urself/rename-details-parameter

Changing the details argument

Author: y0urself

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 ### Changed
 * Added the `tasks` parameter to `get_config()`. [#289](https://github.com/greenbone/python-gvm/pull/289)
+* Renamed `no_details` to `details` in `get_reports()` so it is uniform with all the other calls. [#290](https://github.com/greenbone/python-gvm/pull/290)
 ### Deprecated
 ### Removed
 ### Fixed

gvm/protocols/gmpv7/gmpv7.py

@@ -3620,7 +3620,7 @@ def get_reports(
         filter_id: Optional[str] = None,
         note_details: Optional[bool] = None,
         override_details: Optional[bool] = None,
-        no_details: Optional[bool] = None
+        details: Optional[bool] = None
     ) -> Any:
         """Request a list of reports
 
@@ -3630,7 +3630,7 @@ def get_reports(
             note_details: If notes are included, whether to include note details
             override_details: If overrides are included, whether to include
                 override details
-            no_details: Whether to exclude results
+            details: Whether to exclude results
 
         Returns:
             The response. See :py:meth:`send_command` for details.
@@ -3649,8 +3649,8 @@ def get_reports(
         if override_details is not None:
             cmd.set_attribute("override_details", _to_bool(override_details))
 
-        if no_details is not None:
-            cmd.set_attribute("details", _to_bool(not no_details))
+        if details is not None:
+            cmd.set_attribute("details", _to_bool(details))
 
         cmd.set_attribute("ignore_pagination", "1")
 

tests/protocols/gmpv7/testcmds/test_get_reports.py

@@ -70,14 +70,14 @@ def test_get_reports_with_override_details(self):
         )
 
     def test_get_reports_with_details(self):
-        self.gmp.get_reports(no_details=False)
+        self.gmp.get_reports(details=True)
 
         self.connection.send.has_been_called_with(
             '<get_reports details="1" ignore_pagination="1"/>'
         )
 
     def test_get_reports_without_details(self):
-        self.gmp.get_reports(no_details=True)
+        self.gmp.get_reports(details=False)
 
         self.connection.send.has_been_called_with(
             '<get_reports details="0" ignore_pagination="1"/>'