Skip to content

Commit fe2dc64

Browse files
ozgengreenbonebot
authored andcommitted
Change: Rename modify_agents and delete_agents to modify_agent and delete_agent
1 parent fe824a4 commit fe2dc64

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

gvm/protocols/gmp/requests/next/_agents.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ def modify_agents(
224224
function=cls.modify_agents.__name__, argument="agent_ids"
225225
)
226226

227-
cmd = XmlCommand("modify_agents")
227+
cmd = XmlCommand("modify_agent")
228228
xml_agents = cmd.add_element("agents")
229229

230230
for agent_id in agent_ids:
@@ -256,7 +256,7 @@ def delete_agents(cls, agent_ids: list[EntityID]) -> Request:
256256
function=cls.delete_agents.__name__, argument="agent_ids"
257257
)
258258

259-
cmd = XmlCommand("delete_agents")
259+
cmd = XmlCommand("delete_agent")
260260
xml_agents = cmd.add_element("agents")
261261

262262
for agent_id in agent_ids:

tests/protocols/gmpnext/entities/agents/test_delete_agents.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ def test_delete_agents(self):
1010
self.gmp.delete_agents(agent_ids=["agent-123", "agent-456"])
1111

1212
self.connection.send.has_been_called_with(
13-
b"<delete_agents>"
13+
b"<delete_agent>"
1414
b'<agents><agent id="agent-123"/><agent id="agent-456"/></agents>'
15-
b"</delete_agents>"
15+
b"</delete_agent>"
1616
)
1717

1818
def test_delete_agents_without_ids(self):

tests/protocols/gmpnext/entities/agents/test_modify_agents.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ def test_modify_agents_basic(self):
1010
self.gmp.modify_agents(agent_ids=["agent-123"])
1111

1212
self.connection.send.has_been_called_with(
13-
b"<modify_agents>"
13+
b"<modify_agent>"
1414
b'<agents><agent id="agent-123"/></agents>'
15-
b"</modify_agents>"
15+
b"</modify_agent>"
1616
)
1717

1818
def test_modify_agents_with_authorized_only(self):
@@ -21,10 +21,10 @@ def test_modify_agents_with_authorized_only(self):
2121
)
2222

2323
self.connection.send.has_been_called_with(
24-
b"<modify_agents>"
24+
b"<modify_agent>"
2525
b'<agents><agent id="agent-123"/><agent id="agent-456"/></agents>'
2626
b"<authorized>1</authorized>"
27-
b"</modify_agents>"
27+
b"</modify_agent>"
2828
)
2929

3030
def test_modify_agents_with_full_config_and_comment(self):
@@ -53,7 +53,7 @@ def test_modify_agents_with_full_config_and_comment(self):
5353
)
5454

5555
self.connection.send.has_been_called_with(
56-
b"<modify_agents>"
56+
b"<modify_agent>"
5757
b'<agents><agent id="agent-123"/><agent id="agent-456"/></agents>'
5858
b"<authorized>1</authorized>"
5959
b"<config>"
@@ -78,7 +78,7 @@ def test_modify_agents_with_full_config_and_comment(self):
7878
b"</heartbeat>"
7979
b"</config>"
8080
b"<comment>Updated agents</comment>"
81-
b"</modify_agents>"
81+
b"</modify_agent>"
8282
)
8383

8484
def test_modify_agents_with_full_config_with_missing_element(self):

0 commit comments

Comments
 (0)