Skip to content

fix: address review feedback across client and contracts#31

Merged
Oba-One merged 4 commits intorelease/3.2.0from
codex/review-feedback-fixes
Feb 12, 2026
Merged

fix: address review feedback across client and contracts#31
Oba-One merged 4 commits intorelease/3.2.0from
codex/review-feedback-fixes

Conversation

@Oba-One
Copy link
Member

@Oba-One Oba-One commented Feb 12, 2026

Summary

  • add comprehensive unit coverage for getAccessConfigValidationError across all access types and failure paths
  • fix formatting/indentation issues in metadata and protocol config tests/components
  • prevent duplicate NFT address entries in create flow by normalizing and deduping in StepContent
  • replace direct console usage in NFT gate and hats hook with centralized logger
  • split NFT gate rate limit checks into read-only checks plus record-on-request calls to avoid render-time mutation
  • stabilize ProtocolSelector fallback effect with refs to avoid loops with unstable props
  • update protocolConfigSchema to accept string IDs for hats/hypercert token IDs
  • remove dead mountedRef in useHats, add abort-safe refetch, and validate hat IDs with BigInt
  • add explicit isPoapEventGate discriminator to NftRequirement and update ERC721 branching logic
  • update release doc link and typed client ABI field for isPoapEventGate

Validation

  • forge build
  • FOUNDRY_PROFILE=dev forge test --match-contract CookieJarProtocols -q
  • FOUNDRY_PROFILE=dev forge test --match-contract CookieJar --match-test 'test_WithdrawNFTModeWithTokenId0_UserOwnsToken|test_WithdrawNFTModeWithSpecificTokenId_UserOwnsCorrectToken|test_RevertWhen_WithdrawNFTModeWithSpecificTokenId_UserOwnsDifferentToken' -q

Notes

  • Client-side bun checks were not run in this environment because bun is not installed.

@vercel
Copy link

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cookie-jar Ready Ready Preview, Comment Feb 12, 2026 4:55am

Request Review

@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/review-feedback-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Oba-One Oba-One merged commit c60b912 into release/3.2.0 Feb 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant