Dev into Main

[Oba-One]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cookie-jar	Ready	Preview, Comment	Mar 8, 2026 2:22am

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 652ba312-47df-47de-9860-127d793c72ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

To fix the problem, remove the redundant fallback || "Cookie Jar" from the name field in the catch block, since the earlier if (!metadataString) return guarantees that metadataString is truthy whenever this block executes. We keep the rest of the behavior unchanged: invalid JSON metadata (that is still a non-empty string) will be treated as “legacy description-only metadata” with name equal to the raw string, empty description, and empty image/link.

Concretely, in client/__tests__/MetadataParser.test.tsx, within the parseMetadata function’s catch block (lines 20–25 in the snippet), change name: metadataString || "Cookie Jar", to simply name: metadataString,. No new imports, methods, or other definitions are needed.

In general, to fix “state property written but never read” you either (a) remove the unused state property and any writes to it, or (b) start using it meaningfully. Here, the component already passes errorInfo directly into logError and there’s no evidence that the stateful copy is used elsewhere, so the best fix without changing behaviour is to remove errorInfo from the component state entirely.

Concretely in client/components/app/ProtocolErrorBoundary.tsx:

• Update ProtocolErrorBoundaryState to remove the errorInfo?: React.ErrorInfo; field.
• In componentDidCatch, change this.setState({ error, errorInfo, }); to only set error, since errorInfo will no longer exist on state.
• In the retry method’s setState call, remove errorInfo: undefined from the object, since we no longer track it in state.

No new imports or helper methods are required; we are only simplifying the state shape to match actual usage.

In general, to fix a useless conditional where a negation or condition is always true within its scope, you should either remove the redundant condition or replace it with the condition that actually varies. Here, the entire <CardHeader> block is already guarded by {!isMobile && (...)}, so any additional {!isMobile && ...} inside that block is redundant.

The best minimal fix without changing behavior is to remove the inner {!isMobile && ( ... )} wrapper around the <Progress> component and render <Progress> directly, since we already know !isMobile is true when that code runs. Concretely, in client/components/create/MobileOptimizedForm.tsx, in the <CardHeader> block starting at line 158, replace:

{!isMobile && (
  <Progress value={progressPercentage} className="h-2 mt-2" />
)}

with just:

<Progress value={progressPercentage} className="h-2 mt-2" />

No new methods, imports, or definitions are needed; this is a local JSX cleanup only.

In general, to fix a useless conditional you either (a) wire the condition to a real changing state so it sometimes evaluates differently, or (b) remove the conditional and simplify the expression to its always-taken branch. Since we cannot safely modify the missing surrounding logic (where isLoading is defined) and CodeQL states that isLoading is always false at this use-site, the minimal, behavior-preserving fix is to remove the ternary and use a constant classname.

Concretely, in client/components/nft/UnlockMembershipStatus.tsx, at line 183, replace:

className={`h-4 w-4 ${isLoading ? "animate-spin" : ""}`}

with a static class name string:

className="h-4 w-4"

This keeps rendering the same visual result as before (because "animate-spin" was never actually applied) and removes the useless conditional. No new imports, methods, or additional definitions are required.

In general, to fix this category of issue, you should convert ordinary quoted strings that are intended to interpolate variables into template literals by wrapping them in backticks instead of single or double quotes. This allows ${variableName} placeholders to be evaluated at runtime.

For this specific case in client/config/supported-networks.ts, change the Optimism Sepolia Alchemy URL at line 335 from a double-quoted string to a template literal, matching how the mainnet Alchemy URL on line 323 is handled. Concretely, replace "https://opt-sepolia.g.alchemy.com/v2/${alchemyId}" with `https://opt-sepolia.g.alchemy.com/v2/${alchemyId}`. No new imports or helper functions are required; alchemyId is already defined at line 192, and template literals are standard TypeScript/JavaScript syntax. This preserves existing behavior everywhere else and simply ensures the correct API key is interpolated into the Optimism Sepolia RPC URL.

In general, to fix a useless conditional where a variable is guaranteed to be truthy or falsy at a given point, remove the redundant conditional logic and use the variable directly (or adjust the control flow so that the intended check happens where it still has meaning). This avoids dead code and makes the behavior clearer.

For this specific case in client/lib/blockchain/token-utils.ts, inside formatTokenAmount, the catch block currently returns `${amount || 0} ${symbol}`. Because if (!amount) return ... has already run, amount cannot be undefined there. Using amount || 0 is therefore useless: it will always evaluate to amount, and the 0 fallback is never used. The best fix that preserves existing behavior is to change the return line in the catch block to `${amount} ${symbol}`. No imports or additional helpers are required, and no behavior change occurs for any possible input because the || 0 branch was unreachable.

The only change needed is in this file, in the catch block of formatTokenAmount, around line 100. Replace the expression amount || 0 with just amount.