Skip to content

Commit 10cc3e9

Browse files
committed
Merge tag 'v6.19-rc-part2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6
Pull smb client fixes from Steve French: - Fix incorrect error code defines - Add missing error code definitions - Add parenthesis around NT_STATUS code defines to fix checkpatch warnings - Remove some duplicated protocol definitions, moving to common code shared by client and server - Add missing protocol documentation reference (for change notify) - Correct struct definition (for duplicate_extents_to_file_ex) * tag 'v6.19-rc-part2-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6: smb/client: remove DeviceType Flags and Device Characteristics definitions smb: move File Attributes definitions into common/fscc.h smb: update struct duplicate_extents_to_file_ex smb: move file_notify_information to common/fscc.h smb: move SMB2 Notify Action Flags into common/smb2pdu.h smb: move notify completion filter flags into common/smb2pdu.h smb/client: add parentheses to NT error code definitions containing bitwise OR operator smb: add documentation references for smb2 change notify definitions smb/client: add 4 NT error code definitions smb/client: fix NT_STATUS_UNABLE_TO_FREE_VM value smb/client: fix NT_STATUS_DEVICE_DOOR_OPEN value smb/client: fix NT_STATUS_NO_DATA_DETECTED value
2 parents 6bb34af + ab0347e commit 10cc3e9

File tree

5 files changed

+581
-607
lines changed

5 files changed

+581
-607
lines changed

fs/smb/client/cifspdu.h

Lines changed: 0 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -1357,37 +1357,6 @@ typedef struct smb_com_transaction_change_notify_rsp {
13571357
__u16 ByteCount;
13581358
/* __u8 Pad[3]; */
13591359
} __packed TRANSACT_CHANGE_NOTIFY_RSP;
1360-
/* Completion Filter flags for Notify */
1361-
#define FILE_NOTIFY_CHANGE_FILE_NAME 0x00000001
1362-
#define FILE_NOTIFY_CHANGE_DIR_NAME 0x00000002
1363-
#define FILE_NOTIFY_CHANGE_NAME 0x00000003
1364-
#define FILE_NOTIFY_CHANGE_ATTRIBUTES 0x00000004
1365-
#define FILE_NOTIFY_CHANGE_SIZE 0x00000008
1366-
#define FILE_NOTIFY_CHANGE_LAST_WRITE 0x00000010
1367-
#define FILE_NOTIFY_CHANGE_LAST_ACCESS 0x00000020
1368-
#define FILE_NOTIFY_CHANGE_CREATION 0x00000040
1369-
#define FILE_NOTIFY_CHANGE_EA 0x00000080
1370-
#define FILE_NOTIFY_CHANGE_SECURITY 0x00000100
1371-
#define FILE_NOTIFY_CHANGE_STREAM_NAME 0x00000200
1372-
#define FILE_NOTIFY_CHANGE_STREAM_SIZE 0x00000400
1373-
#define FILE_NOTIFY_CHANGE_STREAM_WRITE 0x00000800
1374-
1375-
#define FILE_ACTION_ADDED 0x00000001
1376-
#define FILE_ACTION_REMOVED 0x00000002
1377-
#define FILE_ACTION_MODIFIED 0x00000003
1378-
#define FILE_ACTION_RENAMED_OLD_NAME 0x00000004
1379-
#define FILE_ACTION_RENAMED_NEW_NAME 0x00000005
1380-
#define FILE_ACTION_ADDED_STREAM 0x00000006
1381-
#define FILE_ACTION_REMOVED_STREAM 0x00000007
1382-
#define FILE_ACTION_MODIFIED_STREAM 0x00000008
1383-
1384-
/* response contains array of the following structures */
1385-
struct file_notify_information {
1386-
__le32 NextEntryOffset;
1387-
__le32 Action;
1388-
__le32 FileNameLength;
1389-
__u8 FileName[];
1390-
} __packed;
13911360

13921361
struct cifs_quota_data {
13931362
__u32 rsrvd1; /* 0 */
@@ -2034,40 +2003,6 @@ typedef struct {
20342003

20352004
#define CIFS_POSIX_EXTENSIONS 0x00000010 /* support for new QFSInfo */
20362005

2037-
/* DeviceType Flags */
2038-
#define FILE_DEVICE_CD_ROM 0x00000002
2039-
#define FILE_DEVICE_CD_ROM_FILE_SYSTEM 0x00000003
2040-
#define FILE_DEVICE_DFS 0x00000006
2041-
#define FILE_DEVICE_DISK 0x00000007
2042-
#define FILE_DEVICE_DISK_FILE_SYSTEM 0x00000008
2043-
#define FILE_DEVICE_FILE_SYSTEM 0x00000009
2044-
#define FILE_DEVICE_NAMED_PIPE 0x00000011
2045-
#define FILE_DEVICE_NETWORK 0x00000012
2046-
#define FILE_DEVICE_NETWORK_FILE_SYSTEM 0x00000014
2047-
#define FILE_DEVICE_NULL 0x00000015
2048-
#define FILE_DEVICE_PARALLEL_PORT 0x00000016
2049-
#define FILE_DEVICE_PRINTER 0x00000018
2050-
#define FILE_DEVICE_SERIAL_PORT 0x0000001b
2051-
#define FILE_DEVICE_STREAMS 0x0000001e
2052-
#define FILE_DEVICE_TAPE 0x0000001f
2053-
#define FILE_DEVICE_TAPE_FILE_SYSTEM 0x00000020
2054-
#define FILE_DEVICE_VIRTUAL_DISK 0x00000024
2055-
#define FILE_DEVICE_NETWORK_REDIRECTOR 0x00000028
2056-
2057-
/* Device Characteristics */
2058-
#define FILE_REMOVABLE_MEDIA 0x00000001
2059-
#define FILE_READ_ONLY_DEVICE 0x00000002
2060-
#define FILE_FLOPPY_DISKETTE 0x00000004
2061-
#define FILE_WRITE_ONCE_MEDIA 0x00000008
2062-
#define FILE_REMOTE_DEVICE 0x00000010
2063-
#define FILE_DEVICE_IS_MOUNTED 0x00000020
2064-
#define FILE_VIRTUAL_VOLUME 0x00000040
2065-
#define FILE_DEVICE_SECURE_OPEN 0x00000100
2066-
#define FILE_CHARACTERISTIC_TS_DEVICE 0x00001000
2067-
#define FILE_CHARACTERISTIC_WEBDAV_DEVICE 0x00002000
2068-
#define FILE_PORTABLE_DEVICE 0x00004000
2069-
#define FILE_DEVICE_ALLOW_APPCONTAINER_TRAVERSAL 0x00020000
2070-
20712006
/******************************************************************************/
20722007
/* QueryFileInfo/QueryPathinfo (also for SetPath/SetFile) data buffer formats */
20732008
/******************************************************************************/

fs/smb/client/nterr.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
const struct nt_err_code_struct nt_errs[] = {
1515
{"NT_STATUS_OK", NT_STATUS_OK},
16+
{"NT_STATUS_PENDING", NT_STATUS_PENDING},
1617
{"NT_STATUS_MEDIA_CHANGED", NT_STATUS_MEDIA_CHANGED},
1718
{"NT_STATUS_END_OF_MEDIA", NT_STATUS_END_OF_MEDIA},
1819
{"NT_STATUS_MEDIA_CHECK", NT_STATUS_MEDIA_CHECK},
@@ -544,6 +545,7 @@ const struct nt_err_code_struct nt_errs[] = {
544545
{"NT_STATUS_DOMAIN_TRUST_INCONSISTENT",
545546
NT_STATUS_DOMAIN_TRUST_INCONSISTENT},
546547
{"NT_STATUS_FS_DRIVER_REQUIRED", NT_STATUS_FS_DRIVER_REQUIRED},
548+
{"NT_STATUS_INVALID_LOCK_RANGE", NT_STATUS_INVALID_LOCK_RANGE},
547549
{"NT_STATUS_NO_USER_SESSION_KEY", NT_STATUS_NO_USER_SESSION_KEY},
548550
{"NT_STATUS_USER_SESSION_DELETED", NT_STATUS_USER_SESSION_DELETED},
549551
{"NT_STATUS_RESOURCE_LANG_NOT_FOUND",
@@ -675,9 +677,12 @@ const struct nt_err_code_struct nt_errs[] = {
675677
NT_STATUS_QUOTA_LIST_INCONSISTENT},
676678
{"NT_STATUS_FILE_IS_OFFLINE", NT_STATUS_FILE_IS_OFFLINE},
677679
{"NT_STATUS_NOT_A_REPARSE_POINT", NT_STATUS_NOT_A_REPARSE_POINT},
680+
{"NT_STATUS_NETWORK_SESSION_EXPIRED", NT_STATUS_NETWORK_SESSION_EXPIRED},
678681
{"NT_STATUS_NO_MORE_ENTRIES", NT_STATUS_NO_MORE_ENTRIES},
679682
{"NT_STATUS_MORE_ENTRIES", NT_STATUS_MORE_ENTRIES},
680683
{"NT_STATUS_SOME_UNMAPPED", NT_STATUS_SOME_UNMAPPED},
681684
{"NT_STATUS_NO_SUCH_JOB", NT_STATUS_NO_SUCH_JOB},
685+
{"NT_STATUS_NO_PREAUTH_INTEGRITY_HASH_OVERLAP",
686+
NT_STATUS_NO_PREAUTH_INTEGRITY_HASH_OVERLAP},
682687
{NULL, 0}
683688
};

0 commit comments

Comments
 (0)