-
-
Notifications
You must be signed in to change notification settings - Fork 36
Open
Description
When copying, options.overwrite should default to true, as documented
filemanager-webpack-plugin/src/options-schema.ts
Lines 38 to 42 in 07b9779
| overwrite: { | |
| description: 'overwrite existing file or directory', | |
| type: 'boolean', | |
| default: true, | |
| }, |
However when the copy source is a glob and overwrite is not specified, fsExtra.copy is called with { overwrite: undefined }, which fs-extra interprets as { overwrite: false }:
filemanager-webpack-plugin/src/utils/glob-copy.ts
Lines 55 to 58 in 07b9779
| const copyOptions = { | |
| overwrite: mergedOptions.overwrite, | |
| preserveTimestamps: mergedOptions.preserveTimestamps, | |
| }; |
This is also an undocumented breaking change between v8.0.0 and v9.0.0.
Metadata
Metadata
Assignees
Labels
No labels