Fix for #38

Author: gretard

src/sonar-sql-plugin/src/main/java/org/antlr/sql/sca/matchers/IndexMatcher.java

@@ -27,7 +27,7 @@ public boolean match(IParsedNode node, RuleImplementation rule) {
                 }
             }
             if (rule.getIndexCheckType() == RuleDistanceIndexMatchType.MORE) {
-                if (rule.getIndex() < val) {
+                if (val < rule.getIndex()) {
                     return false;
                 }
             }
@@ -49,7 +49,7 @@ public boolean match(IParsedNode node, RuleImplementation rule) {
                 }
             }
             if (rule.getIndexCheckType() == RuleDistanceIndexMatchType.MORE) {
-                if (rule.getIndex() < val) {
+                if (val < rule.getIndex()) {
                     return false;
                 }
             }

src/sonar-sql-plugin/src/test/java/org/antlr/sql/sca/matchers/IndexMatcherTest.java

@@ -0,0 +1,36 @@
+package org.antlr.sql.sca.matchers;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.antlr.sql.sca.utils.TestParsedNode;
+import org.junit.Test;
+import org.sonar.plugins.sql.models.rules.RuleDistanceIndexMatchType;
+import org.sonar.plugins.sql.models.rules.RuleImplementation;
+
+public class IndexMatcherTest {
+
+	private final IndexMatcher sut = new IndexMatcher();
+
+	@Test
+	public void testRuleHasZeroIndex() {
+		var node = new TestParsedNode();
+		var rule = new RuleImplementation();
+
+		var result = sut.match(node, rule);
+
+		assertThat(result).isTrue();
+	}
+
+	@Test
+	public void testRuleHasNoneZeroIndexAndExpectsBiggerIndex() {
+		var node = new TestParsedNode();
+		var rule = new RuleImplementation();
+		rule.setIndex(20);
+		rule.setIndexCheckType(RuleDistanceIndexMatchType.MORE);
+
+		var result = sut.match(node, rule);
+
+		assertThat(result).isFalse();
+	}
+
+}

src/sonar-sql-plugin/src/test/java/org/antlr/sql/sca/utils/TestParsedNode.java

@@ -0,0 +1,43 @@
+package org.antlr.sql.sca.utils;
+
+import org.antlr.sql.sca.nodes.IParsedNode;
+
+public class TestParsedNode implements IParsedNode {
+
+	public String text = "SELECT * FROM 1";
+	public String className = TestParsedNode.class.getSimpleName();
+
+	public int index = 1;
+	public int globalIndex = 2;
+
+	@Override
+	public int getIndex() {
+		return index;
+	}
+
+	@Override
+	public int getGlobalIndex() {
+		return globalIndex;
+	}
+
+	@Override
+	public String getClassName() {
+		return className;
+	}
+
+	@Override
+	public String getText() {
+		return text;
+	}
+
+	@Override
+	public int getLine() {
+		return 0;
+	}
+
+	@Override
+	public IParsedNode getControlFlowParent() {
+		return null;
+	}
+
+}