fix: selection plugin configs

Author: afshinm

plugins/selection/src/rowSelection/actions.ts

@@ -1,11 +1,13 @@
 export const CheckRow = (rowId: string) => (state) => {
+  const rowIds = state.rowSelection?.rowIds || [];
+
   // rowId already exists
-  if (state.rowSelection.rowIds.indexOf(rowId) > -1) return state;
+  if (rowIds.indexOf(rowId) > -1) return state;
 
   return {
     ...state,
     rowSelection: {
-      rowIds: [rowId, ...state.rowSelection.rowIds],
+      rowIds: [rowId, ...rowIds],
     },
   };
 };

plugins/selection/src/rowSelection/rowSelection.tsx

@@ -1,3 +1,4 @@
+import { h } from 'preact';
 import * as actions from './actions';
 import { useStore, className, useEffect, useState, useSelector } from 'gridjs';
 import { Row } from 'gridjs';

plugins/selection/tests/rowSelection/actions.test.ts

@@ -1,43 +1,68 @@
-import { Dispatcher } from 'gridjs';
-import { RowSelectionActions } from '../../src/rowSelection/actions';
+import * as Actions from '../../src/rowSelection/actions';
 
 describe('Actions', () => {
-  const dispatcher = new Dispatcher();
+  it('should trigger CHECK', () => {
+    const state = Actions.CheckRow('42')({});
 
-  beforeEach(() => {
-    dispatcher.dispatch = jest.fn();
+    expect(state).toStrictEqual({
+      rowSelection: {
+        rowIds: ['42'],
+      },
+    });
   });
 
-  it('should trigger CHECK', () => {
-    const actions = new RowSelectionActions(dispatcher);
-    actions.check('42');
+  it('should trigger CHECK when rowIds already exists', () => {
+    const state = Actions.CheckRow('42')({
+      rowSelection: {
+        rowIds: ['24'],
+      },
+    });
+
+    expect(state).toStrictEqual({
+      rowSelection: {
+        rowIds: ['42', '24'],
+      },
+    });
+  });
 
-    expect(dispatcher.dispatch).toBeCalledTimes(1);
-    expect(dispatcher.dispatch).toBeCalledWith({
-      payload: {
-        ROW_ID: '42',
+  it('should trigger UNCHECK', () => {
+    const state = Actions.UncheckRow('42')({
+      rowSelection: {
+        rowIds: ['42'],
+      },
+    });
+
+    expect(state).toStrictEqual({
+      rowSelection: {
+        rowIds: [],
       },
-      type: 'CHECK',
     });
   });
 
-  it('should trigger CHECK twice', () => {
-    const actions = new RowSelectionActions(dispatcher);
-    actions.check('1');
-    actions.check('2');
-    expect(dispatcher.dispatch).toBeCalledTimes(2);
+  it('should trigger UNCHECK when rowIds is empty', () => {
+    const state = Actions.UncheckRow('42')({
+      rowSelection: {
+        rowIds: [],
+      },
+    });
+
+    expect(state).toStrictEqual({
+      rowSelection: {
+        rowIds: [],
+      },
+    });
   });
 
-  it('should trigger UNCHECK', () => {
-    const actions = new RowSelectionActions(dispatcher);
-    actions.uncheck('24');
+  it('should CHECK and UNCHECK', () => {
+    let state = {};
+    state = Actions.CheckRow('42')(state);
+    state = Actions.CheckRow('24')(state);
+    state = Actions.UncheckRow('42')(state);
 
-    expect(dispatcher.dispatch).toBeCalledTimes(1);
-    expect(dispatcher.dispatch).toBeCalledWith({
-      payload: {
-        ROW_ID: '24',
+    expect(state).toStrictEqual({
+      rowSelection: {
+        rowIds: ['24'],
       },
-      type: 'UNCHECK',
     });
   });
 });

plugins/selection/tests/rowSelection/store.test.ts

@@ -0,0 +1,12 @@
+{
+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "rootDir": ".",
+    "removeComments": true
+  },
+  "include": [
+    "index.ts",
+    "src/**/*",
+    "tests/**/*"
+  ]
+}

plugins/selection/tsconfig.json

@@ -1,12 +1,14 @@
 {
-  "extends": "../../tsconfig.json",
+  "extends": "./tsconfig.json",
   "compilerOptions": {
     "rootDir": ".",
     "removeComments": true
   },
   "include": [
     "index.ts",
-    "src/**/*",
+    "src/**/*"
+  ],
+  "exclude": [
     "tests/**/*"
   ]
 }

plugins/selection/tsconfig.release.json

@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "types": ["jest"],
+    "esModuleInterop": true
+  }
+}