is.ichildren

Author: softmarshmallow

editor/grida-canvas-react-starter-kit/starterkit-hierarchy/tree-node.tsx

@@ -262,7 +262,7 @@ export function NodeHierarchyList() {
     },
     isItemFolder: (item) => {
       const node = item.getItemData();
-      return "children" in node;
+      return grida.program.nodes.is.ichildren(node);
     },
     onDrop(items, target) {
       const ids = items.map((item) => item.getId());

editor/grida-canvas/reducers/document.reducer.ts

@@ -2025,7 +2025,10 @@ function __self_post_hierarchy_change_commit<
     // Only check boolean and group nodes
     if (parent_node.type === "boolean" || parent_node.type === "group") {
       // Check if the node has children property and if it's empty
-      if ("children" in parent_node && Array.isArray(parent_node.children)) {
+      if (
+        grida.program.nodes.is.ichildren(parent_node) &&
+        Array.isArray(parent_node.children)
+      ) {
         if (parent_node.children.length === 0) {
           // Remove the empty boolean/group node
           self_try_remove_node(draft, parent_id);

editor/grida-canvas/reducers/methods/insert.ts

@@ -21,7 +21,7 @@ export function self_insertSubDocument<S extends editor.state.IEditorState>(
     const parent_node = draft.document.nodes[parent_id];
     assert(parent_node, `Parent node not found with id: "${parent_id}"`);
     assert(
-      "children" in parent_node,
+      grida.program.nodes.is.ichildren(parent_node),
       `Parent must be a container node: "${parent_id}"`
     );
 
@@ -98,7 +98,10 @@ export function self_try_insert_node<S extends editor.state.IEditorState>(
 
     // TODO: this part shall be removed and ensured with data strictness
     // Initialize the parent's children array if it doesn't exist
-    if (!("children" in parent_node) || !parent_node.children) {
+    if (
+      !grida.program.nodes.is.ichildren(parent_node) ||
+      !parent_node.children
+    ) {
       assert(
         parent_node.type === "container",
         "Parent must be a container node"

editor/grida-canvas/reducers/methods/move.ts

@@ -1,5 +1,5 @@
 import type { Draft } from "immer";
-import type grida from "@grida/schema";
+import grida from "@grida/schema";
 import { editor } from "@/grida-canvas";
 import { mv } from "@grida/tree";
 import { dq } from "@/grida-canvas/query";
@@ -30,7 +30,7 @@ export function self_moveNode<S extends editor.state.IEditorState>(
 
   // validate target is a container
   const target = itree[target_id];
-  if (!("children" in target)) {
+  if (!grida.program.nodes.is.ichildren(target)) {
     return false;
   }
 

editor/grida-canvas/reducers/methods/wrap.ts

@@ -196,7 +196,10 @@ export function self_ungroup<S extends editor.state.IEditorState>(
     const node = dq.__getNodeById(draft, node_id);
 
     // Ensure the node has children (group or boolean nodes)
-    if (!("children" in node) || !Array.isArray(node.children)) {
+    if (
+      !grida.program.nodes.is.ichildren(node) ||
+      !Array.isArray(node.children)
+    ) {
       return;
     }
 
@@ -252,7 +255,10 @@ export function self_ungroup<S extends editor.state.IEditorState>(
     } else {
       // Remove from parent's children
       const parent = dq.__getNodeById(draft, parent_id);
-      if ("children" in parent && Array.isArray(parent.children)) {
+      if (
+        grida.program.nodes.is.ichildren(parent) &&
+        Array.isArray(parent.children)
+      ) {
         const index = parent.children.indexOf(node_id);
         if (index !== -1) {
           parent.children.splice(index, 1);

editor/grida-canvas/reducers/tools/target.ts

@@ -42,7 +42,7 @@ export function getRayTarget(
     .filter((node_id) => {
       const node = nodes[node_id];
       const top_id = dq.getTopId(context.document_ctx, node_id);
-      const maybeichildren = ichildren(node);
+      const maybeichildren = childrenOf(node);
 
       // Check if this is a root node with children that should be ignored
       if (
@@ -131,7 +131,7 @@ export function getMarqueeSelection(
     const hit = dq.__getNodeById(state, hit_id);
 
     // (1) shall not be a root node (if configured)
-    const maybeichildren = ichildren(hit);
+    const maybeichildren = childrenOf(hit);
     if (
       maybeichildren &&
       maybeichildren.length > 0 &&
@@ -167,9 +167,9 @@ export function getMarqueeSelection(
   return target_node_ids;
 }
 
-function ichildren(node: any): Array<any> | undefined {
+function childrenOf<T>(node: T): Array<string> | undefined {
   if (!node) return undefined;
-  if ("children" in node && Array.isArray(node.children)) {
+  if (grida.program.nodes.is.ichildren(node) && Array.isArray(node.children)) {
     return node.children;
   }
   return undefined;

packages/grida-canvas-schema/grida.ts

@@ -1923,6 +1923,16 @@ export namespace grida.program.nodes {
     }
   }
 
+  export namespace is {
+    /**
+     * @param node node to check
+     * @returns true if the node is a children reference
+     */
+    export function ichildren(node: any): node is i.IChildrenReference {
+      return "children" in node;
+    }
+  }
+
   type __ReplaceSubset<T, TSubset extends Partial<T>, TNew> = Omit<
     T,
     keyof TSubset
@@ -2644,7 +2654,10 @@ export namespace grida.program.nodes {
       delete prototype._$id;
 
       // Handle children recursively, if the node has children
-      if ("children" in node && Array.isArray(node.children)) {
+      if (
+        grida.program.nodes.is.ichildren(node) &&
+        Array.isArray(node.children)
+      ) {
         (prototype as __IPrototypeNodeChildren).children = node.children.map(
           (childId) => createPrototypeFromSnapshot(snapshot, childId)
         );