Merge pull request #85 from gridsmartercities/fix_null_with_regex

fixed mandatory with regex when field is missing

Author: zoltax

aws_lambda_decorators/validators.py

@@ -77,6 +77,9 @@ def validate(self, value=None):
         Args:
             value (str): Value to be validated.
         """
+        if not value:
+            return True
+
         return self._regexp.fullmatch(value) is not None
 
 

setup.py

@@ -3,7 +3,7 @@
 LONG_DESCRIPTION = open('README.md').read()
 
 setup(name='aws-lambda-decorators',
-      version='0.32',
+      version='0.33',
       description='A set of python decorators to simplify aws python lambda development',
       long_description=LONG_DESCRIPTION,
       long_description_content_type="text/markdown",

tests/test_decorators.py

@@ -1257,3 +1257,21 @@ def handler(event, context, c=None, d=None):  # noqa: pylint - unused-argument
                 ]}
             ]
         )
+
+    def test_extract_returns_400_on_missing_mandatory_key_with_regex(self):
+        path = "/a/b/c"
+        dictionary = {
+            "a": {
+                "b": {
+                }
+            }
+        }
+
+        @extract([Parameter(path, 'event', validators=[Mandatory, RegexValidator("[0-9]+")])], group_errors=True)
+        def handler(event, context, c=None):  # noqa
+            return {}
+
+        response = handler(dictionary, None)
+
+        self.assertEqual(400, response["statusCode"])
+        self.assertEqual('{"message": [{"c": ["Missing mandatory value"]}]}', response["body"])