fix: handle config param api in commons-ui (app specific) (#838)

Signed-off-by: Joris Mancini <[email protected]>

Author: TheMaskedTurtle

src/components/directoryItemSelector/utils.ts

@@ -6,7 +6,7 @@
  */
 
 import { UUID } from 'crypto';
-import { ElementAttributes, ElementType, LAST_SELECTED_DIRECTORY } from '../../utils';
+import { COMMON_APP_NAME, ElementAttributes, ElementType, LAST_SELECTED_DIRECTORY } from '../../utils';
 import { fetchDirectoryElementPath, updateConfigParameter } from '../../services';
 
 /**
@@ -30,7 +30,7 @@ export async function clearLastSelectedDirectory(): Promise<void> {
     localStorage.removeItem(LAST_SELECTED_DIRECTORY);
 
     try {
-        await updateConfigParameter(LAST_SELECTED_DIRECTORY, 'null');
+        await updateConfigParameter(COMMON_APP_NAME, LAST_SELECTED_DIRECTORY, 'null');
     } catch (error) {
         console.error('Failed to clear last selected directory:', error);
     }
@@ -42,7 +42,7 @@ export async function clearLastSelectedDirectory(): Promise<void> {
  */
 export async function saveLastSelectedDirectory(directoryId: UUID): Promise<void> {
     try {
-        await updateConfigParameter(LAST_SELECTED_DIRECTORY, directoryId);
+        await updateConfigParameter(COMMON_APP_NAME, LAST_SELECTED_DIRECTORY, directoryId);
     } catch (error) {
         console.error('Failed to save last selected directory:', error);
     }

src/services/directory.ts

@@ -7,18 +7,35 @@
 
 import { UUID } from 'crypto';
 import { backendFetch, backendFetchJson, getRequestParamFromList } from './utils';
-import { ElementAttributes } from '../utils';
+import { COMMON_APP_NAME, COMMON_CONFIG_PARAMS_NAMES, ElementAttributes } from '../utils';
 
 const PREFIX_EXPLORE_SERVER_QUERIES = `${import.meta.env.VITE_API_GATEWAY}/explore`;
 const PREFIX_CONFIG_QUERIES = `${import.meta.env.VITE_API_GATEWAY}/config`;
 
-export function updateConfigParameter(name: string, value: string) {
-    const appName = 'common';
-    console.info("Updating config parameter '%s=%s' for app '%s' ", name, value, appName);
-    const updateParams = `${PREFIX_CONFIG_QUERIES}/v1/applications/${appName}/parameters/${name}?value=${encodeURIComponent(value)}`;
+export function getAppName(appName: string, name: string) {
+    return COMMON_CONFIG_PARAMS_NAMES.has(name) ? COMMON_APP_NAME : appName;
+}
+
+export function updateConfigParameter(appName: string, name: string, value: string) {
+    const targetAppName = getAppName(appName, name);
+    console.info(`Updating config parameter '${name}=${value}' for app '${targetAppName}'`);
+    const updateParams = `${PREFIX_CONFIG_QUERIES}/v1/applications/${targetAppName}/parameters/${name}?value=${encodeURIComponent(value)}`;
     return backendFetch(updateParams, { method: 'put' });
 }
 
+export function fetchConfigParameters(appName: string) {
+    console.info(`Fetching UI configuration params for app : ${appName}`);
+    const fetchParams = `${PREFIX_CONFIG_QUERIES}/v1/applications/${appName}/parameters`;
+    return backendFetchJson(fetchParams);
+}
+
+export function fetchConfigParameter(appName: string, name: string) {
+    const targetAppName = getAppName(appName, name);
+    console.info(`Fetching UI config parameter '${name}' for app '${targetAppName}'`);
+    const fetchParams = `${PREFIX_CONFIG_QUERIES}/v1/applications/${targetAppName}/parameters/${name}`;
+    return backendFetchJson(fetchParams);
+}
+
 export function fetchRootFolders(types: string[]): Promise<ElementAttributes[]> {
     console.info('Fetching Root Directories');
 

src/utils/constants/configConstants.ts

@@ -9,3 +9,12 @@ export const PARAM_THEME = 'theme';
 export const PARAM_LANGUAGE = 'language';
 export const PARAM_DEVELOPER_MODE = 'enableDeveloperMode';
 export const LAST_SELECTED_DIRECTORY = 'lastSelectedDirectory';
+
+export const COMMON_CONFIG_PARAMS_NAMES = new Set([
+    PARAM_THEME,
+    PARAM_LANGUAGE,
+    LAST_SELECTED_DIRECTORY,
+    PARAM_DEVELOPER_MODE,
+]);
+
+export const COMMON_APP_NAME = 'common';